src/core/SkImageFilter.cpp - Issue 395603002: Simplify flattening to just write enough to call the factory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkImageFilter.cpp

Issue 395603002: Simplify flattening to just write enough to call the factory (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkImageFilter.cpp

diff --git a/src/core/SkImageFilter.cpp b/src/core/SkImageFilter.cpp

index 3eb688e2c74d9848cfdd5a0028ecf159db7edfa7..b172820a02e9ae4b63888def4e4f92c07c7cf5b4 100644

--- a/src/core/SkImageFilter.cpp

+++ b/src/core/SkImageFilter.cpp

@@ -102,7 +102,7 @@ SkImageFilter::SkImageFilter(int inputCount, SkReadBuffer& buffer) {

}

-void SkImageFilter::flatten(SkWriteBuffer& buffer) const {

+void SkImageFilter::flattenCommon(SkWriteBuffer& buffer) const {

buffer.writeInt(fInputCount);

for (int i = 0; i < fInputCount; i++) {

SkImageFilter* input = getInput(i);