Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Unified Diff: chrome/browser/sync/sync_error_notifier_ash.cc

Issue 395463005: Make sync/sign-in error notifications actionable on click. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/signin/signin_error_notifier_ash.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/sync_error_notifier_ash.cc
diff --git a/chrome/browser/sync/sync_error_notifier_ash.cc b/chrome/browser/sync/sync_error_notifier_ash.cc
index 373186d062b9378b50019eb96ee90a15de891c17..473738e28f8414bc645b341edd7a6bc67fc8ce0d 100644
--- a/chrome/browser/sync/sync_error_notifier_ash.cc
+++ b/chrome/browser/sync/sync_error_notifier_ash.cc
@@ -57,6 +57,8 @@ class SyncNotificationDelegate : public NotificationDelegate {
virtual ~SyncNotificationDelegate();
private:
+ void ShowSyncSetup();
+
// Unique id of the notification.
const std::string id_;
@@ -89,6 +91,11 @@ bool SyncNotificationDelegate::HasClickedListener() {
}
void SyncNotificationDelegate::Click() {
+ ShowSyncSetup();
+}
+
+void SyncNotificationDelegate::ButtonClick(int button_index) {
+ ShowSyncSetup();
}
std::string SyncNotificationDelegate::id() const {
@@ -99,7 +106,7 @@ content::WebContents* SyncNotificationDelegate::GetWebContents() const {
return NULL;
}
-void SyncNotificationDelegate::ButtonClick(int button_index) {
+void SyncNotificationDelegate::ShowSyncSetup() {
LoginUIService* login_ui = LoginUIServiceFactory::GetForProfile(profile_);
if (login_ui->current_login_ui()) {
// TODO(michaelpg): The LoginUI might be on an inactive desktop.
« no previous file with comments | « chrome/browser/signin/signin_error_notifier_ash.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698