Make sync/sign-in error notifications actionable on click.

chrome/browser/sync/sync_error_notifier_ash.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/sync_error_notifier_ash.h"
 
 #include "ash/shell.h"
 #include "ash/shell_delegate.h"
 #include "ash/system/system_notifier.h"
 #include "base/strings/string16.h"
@@ skipping 39 matching lines @@
   virtual bool HasClickedListener() OVERRIDE;
   virtual void Click() OVERRIDE;
   virtual void ButtonClick(int button_index) OVERRIDE;
   virtual std::string id() const OVERRIDE;
   virtual content::WebContents* GetWebContents() const OVERRIDE;
 
  protected:
   virtual ~SyncNotificationDelegate();
 
  private:
+  void ShowSyncSetup();
+
   // Unique id of the notification.
   const std::string id_;
 
   Profile* profile_;
 
   DISALLOW_COPY_AND_ASSIGN(SyncNotificationDelegate);
 };
 
 SyncNotificationDelegate::SyncNotificationDelegate(
     const std::string& id,
@@ skipping 12 matching lines @@
 }
 
 void SyncNotificationDelegate::Close(bool by_user) {
 }
 
 bool SyncNotificationDelegate::HasClickedListener() {
   return false;
 }
 
 void SyncNotificationDelegate::Click() {
+  ShowSyncSetup();
+}
+
+void SyncNotificationDelegate::ButtonClick(int button_index) {
+  ShowSyncSetup();
 }
 
 std::string SyncNotificationDelegate::id() const {
   return id_;
 }
 
 content::WebContents* SyncNotificationDelegate::GetWebContents() const {
   return NULL;
 }
 
-void SyncNotificationDelegate::ButtonClick(int button_index) {
+void SyncNotificationDelegate::ShowSyncSetup() {
   LoginUIService* login_ui = LoginUIServiceFactory::GetForProfile(profile_);
   if (login_ui->current_login_ui()) {
     // TODO(michaelpg): The LoginUI might be on an inactive desktop.
     // See crbug.com/354280.
     login_ui->current_login_ui()->FocusUI();
     return;
   }
 
   chrome::ShowSettingsSubPageForProfile(profile_, chrome::kSyncSetupSubPage);
 }
@@ skipping 76 matching lines @@
       ui::ResourceBundle::GetSharedInstance().GetImageNamed(
           IDR_NOTIFICATION_ALERT),
       blink::WebTextDirectionDefault,
       notifier_id,
       base::string16(),  // display_source
       base::ASCIIToUTF16(notification_id_),
       data,
       delegate);
   notification_ui_manager->Add(notification, profile_);
 }