Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 395463005: Make sync/sign-in error notifications actionable on click. (Closed)

Created:
6 years, 5 months ago by michaelpg
Modified:
6 years, 5 months ago
CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, zea+watch_chromium.org, maniscalco+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Make sync/sign-in error notifications actionable on click. Since there is only one button, clicking the notification will perform the same action as the button per PM/designer decision. BUG=393680 R=atwilson@chromium.org TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283438

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -9 lines) Patch
M chrome/browser/signin/signin_error_notifier_ash.cc View 3 chunks +15 lines, -8 lines 0 comments Download
M chrome/browser/sync/sync_error_notifier_ash.cc View 3 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
michaelpg
6 years, 5 months ago (2014-07-14 21:21:30 UTC) #1
Andrew T Wilson (Slow)
lgtm
6 years, 5 months ago (2014-07-15 10:03:19 UTC) #2
michaelpg
The CQ bit was checked by michaelpg@chromium.org
6 years, 5 months ago (2014-07-15 17:48:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaelpg@chromium.org/395463005/1
6 years, 5 months ago (2014-07-15 17:52:51 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-16 02:23:43 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-16 02:42:42 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/39282)
6 years, 5 months ago (2014-07-16 02:42:43 UTC) #7
michaelpg
The CQ bit was checked by michaelpg@chromium.org
6 years, 5 months ago (2014-07-16 03:41:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaelpg@chromium.org/395463005/1
6 years, 5 months ago (2014-07-16 03:43:25 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 18:21:27 UTC) #10
Message was sent while issue was closed.
Change committed as 283438

Powered by Google App Engine
This is Rietveld 408576698