Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Unified Diff: Source/core/rendering/RenderObject.h

Issue 395463003: Invalidate previous paint rect in RenderObject::paintInvalidationForWholeRenderer() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Add savesPreviousPaintInvalidationRect; Remove extra optimization code Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/RenderObject.h
diff --git a/Source/core/rendering/RenderObject.h b/Source/core/rendering/RenderObject.h
index d0fab2e388e5d315914104eb7a911e29a24816aa..00b727bf440806f8d27063a39b3c791538a63b86 100644
--- a/Source/core/rendering/RenderObject.h
+++ b/Source/core/rendering/RenderObject.h
@@ -989,8 +989,18 @@ public:
bool isRelayoutBoundaryForInspector() const;
- const LayoutRect& previousPaintInvalidationRect() const { return m_previousPaintInvalidationRect; }
- void setPreviousPaintInvalidationRect(const LayoutRect& rect) { m_previousPaintInvalidationRect = rect; }
+ const LayoutRect& previousPaintInvalidationRect() const
+ {
+ ASSERT(savesPreviousPaintInvalidationRect());
+ return m_previousPaintInvalidationRect;
+ }
+ void setPreviousPaintInvalidationRect(const LayoutRect& rect)
+ {
+ ASSERT(savesPreviousPaintInvalidationRect());
+ m_previousPaintInvalidationRect = rect;
+ }
+ // For now only RenderBox and RenderSVGModelObject sets previousPaintInvalidationRect.
+ bool savesPreviousPaintInvalidationRect() const { return isBox() || isSVG(); }
const LayoutPoint& previousPositionFromPaintInvalidationContainer() const { return m_previousPositionFromPaintInvalidationContainer; }
void setPreviousPositionFromPaintInvalidationContainer(const LayoutPoint& location) { m_previousPositionFromPaintInvalidationContainer = location; }

Powered by Google App Engine
This is Rietveld 408576698