Extensions: Move cast_channel and hid APIs to extensions/.

Extensions: Move bluetooth APIs to extensions/.

BUG=395240
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285687

[Ken Rockot(use gerrit already), 2014-07-18 20:11:59]

Very nice. LGTM!

[Ken Rockot(use gerrit already), 2014-07-18 20:13:06]

On 2014/07/18 20:11:59, Ken Rockot wrote:
> Very nice. LGTM!

PS: Could you please file and/or link to a bug relevant to this change. Curious
about the motivation apart from the general greatness of componentization.

[Lei Zhang, 2014-07-18 20:15:37]

On 2014/07/18 20:13:06, Ken Rockot wrote:
> On 2014/07/18 20:11:59, Ken Rockot wrote:
> > Very nice. LGTM!
> 
> PS: Could you please file and/or link to a bug relevant to this change.
Curious
> about the motivation apart from the general greatness of componentization.

I don't know of any, so I filed http://crbug.com/395240

[Lei Zhang, 2014-07-18 20:15:49]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-07-18 20:17:10]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thestig@chromium.org/395333003/40001

[commit-bot: I haz the power, 2014-07-18 23:26:13]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  mac_gpu_retina_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_retina_tr...)

[Lei Zhang, 2014-07-18 23:29:05]

The CQ bit was unchecked by thestig@chromium.org

[commit-bot: I haz the power, 2014-07-18 23:29:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-18 23:29:08]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  mac_gpu_retina_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_retina_tr...)

[Lei Zhang, 2014-07-18 23:29:26]

+yoz for apps/shell

[Lei Zhang, 2014-07-24 21:05:56]

On 2014/07/18 23:29:26, Lei Zhang wrote:
> +yoz for apps/shell

ping

[Yoyo Zhou, 2014-07-24 21:21:34]

Sorry I missed this earlier. Please ping sooner! LGTM

https://codereview.chromium.org/395333003/diff/40001/extensions/extensions.gyp
File extensions/extensions.gyp (right):

https://codereview.chromium.org/395333003/diff/40001/extensions/extensions.gy...
extensions/extensions.gyp:507: 'sources': [
Why are there two 'sources' here?

[Ken Rockot(use gerrit already), 2014-07-24 21:23:32]

https://codereview.chromium.org/395333003/diff/40001/extensions/extensions.gyp
File extensions/extensions.gyp (right):

https://codereview.chromium.org/395333003/diff/40001/extensions/extensions.gy...
extensions/extensions.gyp:507: 'sources': [
On 2014/07/24 21:21:34, Yoyo Zhou wrote:
> Why are there two 'sources' here?

Looks like one is for use_openssl==1 and the other is for use_openssl==0

[Yoyo Zhou, 2014-07-24 21:24:27]

https://codereview.chromium.org/395333003/diff/40001/extensions/extensions.gyp
File extensions/extensions.gyp (right):

https://codereview.chromium.org/395333003/diff/40001/extensions/extensions.gy...
extensions/extensions.gyp:507: 'sources': [
On 2014/07/24 21:23:32, Ken Rockot wrote:
> On 2014/07/24 21:21:34, Yoyo Zhou wrote:
> > Why are there two 'sources' here?
> 
> Looks like one is for use_openssl==1 and the other is for use_openssl==0

Ah, thanks.

[Lei Zhang, 2014-07-24 23:37:11]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-07-24 23:38:32]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thestig@chromium.org/395333003/60001

[Lei Zhang, 2014-07-25 02:17:29]

The CQ bit was unchecked by thestig@chromium.org

[Lei Zhang, 2014-07-25 02:22:40]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-07-25 02:25:51]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thestig@chromium.org/395333003/80001

[commit-bot: I haz the power, 2014-07-25 04:42:26]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/9...)
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/21...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel_swarming on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel_sw...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win8_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win8_chromium_rel/bui...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/38201)

[commit-bot: I haz the power, 2014-07-25 04:46:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-25 04:46:39]

Try jobs failed on following builders:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/9...)
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/21...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel_swarming on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel_sw...)
  win8_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win8_chromium_rel/bui...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[Lei Zhang, 2014-07-25 19:32:17]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-07-25 19:32:39]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thestig@chromium.org/395333003/100001

[commit-bot: I haz the power, 2014-07-25 21:44:47]

Change committed as 285687

[mark a. foltz, 2014-07-26 23:15:10]

On 2014/07/25 21:44:47, I haz the power (commit-bot) wrote:
> Change committed as 285687

FYI,

cast_channel doesn't have anything to do with Bluetooth or HID.  Please CC
OWNERs from cast_channel/OWNERS (mfoltz@, wez@, munja@) for future changes
affecting these files.

m.

[Lei Zhang, 2014-07-30 05:39:10]

On 2014/07/26 23:15:10, mark a. foltz wrote:
> On 2014/07/25 21:44:47, I haz the power (commit-bot) wrote:
> > Change committed as 285687
> 
> FYI,
> 
> cast_channel doesn't have anything to do with Bluetooth or HID.  Please CC
> OWNERs from cast_channel/OWNERS (mfoltz@, wez@, munja@) for future changes
> affecting these files.
> 
> m.

I would suggest adding yourselves to the WATCHLISTS file [1], rather than hoping
other developers will remember to CC you. If you do have any concerns regarding
this CL, please let me know.

[1] http://dev.chromium.org/developers/contributing-code/watchlists