Issue 395203002: Revert of Reopened: Caching the result of readPixelsSupported

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 395203002: Revert of Reopened: Caching the result of readPixelsSupported (Closed)

Created:
6 years, 5 months ago by bungeman-skia

Modified:
6 years, 5 months ago

Reviewers:
reed2, Justin Novosad, Rémi Piotaix, bsalomon, bsalomon_chromium, mtklein

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Revert of Reopened: Caching the result of readPixelsSupported (https://codereview.chromium.org/364193004/) Reason for revert: This appears to be causing failures on Android when running tests. Original issue's description: > Caching the result of readPixelsSupported > > The call was calling GR_GL_GetIntegerv 2 times for each readPixels > and thus was causing a loss of performance > > (resubmit of issue 344793008) > > Benchmark url: http://packages.gkny.fr/tst/index.html > > BUG=skia:2681 > > Committed: https://skia.googlesource.com/skia/+/753a2964afe5661ce9b2a8ca77ca9d0aabd3173c > > Committed: https://skia.googlesource.com/skia/+/8339371f1ec3c57a0741932fd96bff32c53d4e54 TBR=junov@chromium.org,reed@chromium.org,bsalomon@chromium.org,mtklein@google.com,bsalomon@google.com,piotaixr@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia:2681 Committed: https://skia.googlesource.com/skia/+/c7af812b4213105264af514d13ddbe631a89d171

Created: 6 years, 5 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -252 lines)			Patch
M	gyp/core.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	gyp/tests.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	src/core/SkTHashCache.h	View	1 chunk	+0 lines, -77 lines	0 comments	Download
M	src/gpu/gl/GrGLCaps.h	View	4 chunks	+2 lines, -48 lines	0 comments	Download
M	src/gpu/gl/GrGLCaps.cpp	View	4 chunks	+4 lines, -26 lines	0 comments	Download
M	src/gpu/gl/GrGpuGL.cpp	View	3 chunks	+6 lines, -8 lines	0 comments	Download
D	tests/THashCache.cpp	View	1 chunk	+0 lines, -91 lines	0 comments	Download

Total messages: 3 (0 generated)

bungeman-skia

Created Revert of Reopened: Caching the result of readPixelsSupported

6 years, 5 months ago (2014-07-16 16:09:58 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bungeman@google.com/395203002/1

6 years, 5 months ago (2014-07-16 16:10:34 UTC) #2

commit-bot: I haz the power

6 years, 5 months ago (2014-07-16 16:10:49 UTC) #3

Message was sent while issue was closed.

Change committed as c7af812b4213105264af514d13ddbe631a89d171