Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 395203002: Revert of Reopened: Caching the result of readPixelsSupported (Closed)

Created:
6 years, 5 months ago by bungeman-skia
Modified:
6 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Revert of Reopened: Caching the result of readPixelsSupported (https://codereview.chromium.org/364193004/) Reason for revert: This appears to be causing failures on Android when running tests. Original issue's description: > Caching the result of readPixelsSupported > > The call was calling GR_GL_GetIntegerv 2 times for each readPixels > and thus was causing a loss of performance > > (resubmit of issue 344793008) > > Benchmark url: http://packages.gkny.fr/tst/index.html > > BUG=skia:2681 > > Committed: https://skia.googlesource.com/skia/+/753a2964afe5661ce9b2a8ca77ca9d0aabd3173c > > Committed: https://skia.googlesource.com/skia/+/8339371f1ec3c57a0741932fd96bff32c53d4e54 TBR=junov@chromium.org,reed@chromium.org,bsalomon@chromium.org,mtklein@google.com,bsalomon@google.com,piotaixr@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia:2681 Committed: https://skia.googlesource.com/skia/+/c7af812b4213105264af514d13ddbe631a89d171

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -252 lines) Patch
M gyp/core.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D src/core/SkTHashCache.h View 1 chunk +0 lines, -77 lines 0 comments Download
M src/gpu/gl/GrGLCaps.h View 4 chunks +2 lines, -48 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 4 chunks +4 lines, -26 lines 0 comments Download
M src/gpu/gl/GrGpuGL.cpp View 3 chunks +6 lines, -8 lines 0 comments Download
D tests/THashCache.cpp View 1 chunk +0 lines, -91 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
bungeman-skia
Created Revert of Reopened: Caching the result of readPixelsSupported
6 years, 5 months ago (2014-07-16 16:09:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bungeman@google.com/395203002/1
6 years, 5 months ago (2014-07-16 16:10:34 UTC) #2
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 16:10:49 UTC) #3
Message was sent while issue was closed.
Change committed as c7af812b4213105264af514d13ddbe631a89d171

Powered by Google App Engine
This is Rietveld 408576698