Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 395133008: [telemetry] rasterize_and_record_micro: Increase timeout for document to load (Closed)

Created:
6 years, 5 months ago by gordanac
Modified:
6 years, 5 months ago
Reviewers:
tonyg, vmpstr
CC:
chromium-reviews, telemetry+watch_chromium.org, petar.jovanovic, Paul Lind
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[telemetry] rasterize_and_record_micro: Increase timeout for document to load Increasing wait time for document's state to become 'complete'. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284220

Patch Set 1 #

Total comments: 2

Patch Set 2 : Replace tab.WaitForJavaScriptExpression() by tab.WaitForDocumentReadyStateToBeComplete() #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/perf/measurements/rasterize_and_record_micro.py View 1 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 7 (0 generated)
gordanac
Please take a look.
6 years, 5 months ago (2014-07-17 16:54:12 UTC) #1
tonyg
https://codereview.chromium.org/395133008/diff/1/tools/perf/measurements/rasterize_and_record_micro.py File tools/perf/measurements/rasterize_and_record_micro.py (right): https://codereview.chromium.org/395133008/diff/1/tools/perf/measurements/rasterize_and_record_micro.py#newcode61 tools/perf/measurements/rasterize_and_record_micro.py:61: tab.WaitForJavaScriptExpression("document.readyState == 'complete'", 30) Good catch. Let's change this ...
6 years, 5 months ago (2014-07-17 17:02:02 UTC) #2
gordanac
https://codereview.chromium.org/395133008/diff/1/tools/perf/measurements/rasterize_and_record_micro.py File tools/perf/measurements/rasterize_and_record_micro.py (right): https://codereview.chromium.org/395133008/diff/1/tools/perf/measurements/rasterize_and_record_micro.py#newcode61 tools/perf/measurements/rasterize_and_record_micro.py:61: tab.WaitForJavaScriptExpression("document.readyState == 'complete'", 30) On 2014/07/17 17:02:02, tonyg wrote: ...
6 years, 5 months ago (2014-07-18 09:25:58 UTC) #3
tonyg
lgtm https://codereview.chromium.org/395133008/diff/20001/tools/perf/measurements/rasterize_and_record_micro.py File tools/perf/measurements/rasterize_and_record_micro.py (right): https://codereview.chromium.org/395133008/diff/20001/tools/perf/measurements/rasterize_and_record_micro.py#newcode62 tools/perf/measurements/rasterize_and_record_micro.py:62: except TimeoutException: This is something for a follow-up ...
6 years, 5 months ago (2014-07-18 15:17:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Gordana.Cmiljanovic@imgtec.com/395133008/20001
6 years, 5 months ago (2014-07-18 15:18:52 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-18 19:44:18 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 22:18:46 UTC) #7
Message was sent while issue was closed. 
Change committed as 284220

Powered by Google App Engine
This is Rietveld 408576698