tools/perf/measurements/rasterize_and_record_micro.py - Issue 395133008: [telemetry] rasterize_and_record_micro: Increase timeout for document to load

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/measurements/rasterize_and_record_micro.py

Issue 395133008: [telemetry] rasterize_and_record_micro: Increase timeout for document to load (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Replace tab.WaitForJavaScriptExpression() by tab.WaitForDocumentReadyStateToBeComplete() Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/measurements/rasterize_and_record_micro.py

diff --git a/tools/perf/measurements/rasterize_and_record_micro.py b/tools/perf/measurements/rasterize_and_record_micro.py

index 92f5881e8f5505cf92248cbb5f7cbc243110a717..8f852ee1d4ac5c7cb9aebbaa11b29da312683029 100644

--- a/tools/perf/measurements/rasterize_and_record_micro.py

+++ b/tools/perf/measurements/rasterize_and_record_micro.py

@@ -58,7 +58,7 @@ class RasterizeAndRecordMicro(page_measurement.PageMeasurement):

def MeasurePage(self, page, tab, results):

try:

- tab.WaitForJavaScriptExpression("document.readyState == 'complete'", 10)

+ tab.WaitForDocumentReadyStateToBeComplete()

except TimeoutException:

tonyg 2014/07/18 15:17:27 This is something for a follow-up CL, not this one

pass

time.sleep(self.options.start_wait_time)

« no previous file with comments | « no previous file | no next file » | no next file with comments »