Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 394953005: Caret is showing after do a copy operation from editable field. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
index 004aefd7694173df61b79a8a281c5d1447806afc..60702019c33b02c920cb4f442a6fe066239847ee 100644
--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
@@ -2192,6 +2192,7 @@ public class ContentViewCore
if (isSelectionEditable()) {
int selectionEnd = Selection.getSelectionEnd(mEditable);
mInputConnection.setSelection(selectionEnd, selectionEnd);
+ hideHandles();
jdduke (slow) 2014/07/16 15:08:59 Is there any downside to moving the |hideHandles()
AKVT 2014/07/16 16:39:09 Thanks for reviewing. mImeAdapter.unselect() takes
jdduke (slow) 2014/07/16 18:14:23 I realize handles in a non-editable region are hid
AKVT 2014/07/17 03:03:12 Done.
} else {
mImeAdapter.unselect();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698