Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Side by Side Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 394953005: Caret is showing after do a copy operation from editable field. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.content.browser; 5 package org.chromium.content.browser;
6 6
7 import android.annotation.SuppressLint; 7 import android.annotation.SuppressLint;
8 import android.app.Activity; 8 import android.app.Activity;
9 import android.app.SearchManager; 9 import android.app.SearchManager;
10 import android.content.ContentResolver; 10 import android.content.ContentResolver;
(...skipping 2174 matching lines...) Expand 10 before | Expand all | Expand 10 after
2185 return mFocusedNodeEditable; 2185 return mFocusedNodeEditable;
2186 } 2186 }
2187 2187
2188 @Override 2188 @Override
2189 public void onDestroyActionMode() { 2189 public void onDestroyActionMode() {
2190 mActionMode = null; 2190 mActionMode = null;
2191 if (mUnselectAllOnActionModeDismiss) { 2191 if (mUnselectAllOnActionModeDismiss) {
2192 if (isSelectionEditable()) { 2192 if (isSelectionEditable()) {
2193 int selectionEnd = Selection.getSelectionEnd(mEditable); 2193 int selectionEnd = Selection.getSelectionEnd(mEditable);
2194 mInputConnection.setSelection(selectionEnd, selectionEnd ); 2194 mInputConnection.setSelection(selectionEnd, selectionEnd );
2195 hideHandles();
jdduke (slow) 2014/07/16 15:08:59 Is there any downside to moving the |hideHandles()
AKVT 2014/07/16 16:39:09 Thanks for reviewing. mImeAdapter.unselect() takes
jdduke (slow) 2014/07/16 18:14:23 I realize handles in a non-editable region are hid
AKVT 2014/07/17 03:03:12 Done.
2195 } else { 2196 } else {
2196 mImeAdapter.unselect(); 2197 mImeAdapter.unselect();
2197 } 2198 }
2198 } 2199 }
2199 getContentViewClient().onContextualActionBarHidden(); 2200 getContentViewClient().onContextualActionBarHidden();
2200 } 2201 }
2201 2202
2202 @Override 2203 @Override
2203 public boolean isShareAvailable() { 2204 public boolean isShareAvailable() {
2204 Intent intent = new Intent(Intent.ACTION_SEND); 2205 Intent intent = new Intent(Intent.ACTION_SEND);
(...skipping 1187 matching lines...) Expand 10 before | Expand all | Expand 10 after
3392 3393
3393 private native void nativeExtractSmartClipData(long nativeContentViewCoreImp l, 3394 private native void nativeExtractSmartClipData(long nativeContentViewCoreImp l,
3394 int x, int y, int w, int h); 3395 int x, int y, int w, int h);
3395 private native void nativeSetBackgroundOpaque(long nativeContentViewCoreImpl , boolean opaque); 3396 private native void nativeSetBackgroundOpaque(long nativeContentViewCoreImpl , boolean opaque);
3396 3397
3397 private native void nativeResumeResponseDeferredAtStart( 3398 private native void nativeResumeResponseDeferredAtStart(
3398 long nativeContentViewCoreImpl); 3399 long nativeContentViewCoreImpl);
3399 private native void nativeSetHasPendingNavigationTransitionForTesting( 3400 private native void nativeSetHasPendingNavigationTransitionForTesting(
3400 long nativeContentViewCoreImpl); 3401 long nativeContentViewCoreImpl);
3401 } 3402 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698