Source/core/html/forms/BaseDateAndTimeInputType.cpp - Issue 394903004: document.lastModified should consider user's local time zone

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/forms/BaseDateAndTimeInputType.cpp

Issue 394903004: document.lastModified should consider user's local time zone (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix windows build error Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/http/tests/misc/last-modified-parsing.html ('K') | « Source/core/dom/Document.cpp ('k') | Source/core/html/forms/MonthInputType.cpp » ('j') | Source/core/html/forms/MonthInputType.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/forms/BaseDateAndTimeInputType.cpp

diff --git a/Source/core/html/forms/BaseDateAndTimeInputType.cpp b/Source/core/html/forms/BaseDateAndTimeInputType.cpp

index 309d013f5feb1770f9ae170948a45a7d7920976b..de2238b92d0e77b9c1ac4e582dc4ec59993ed43d 100644

--- a/Source/core/html/forms/BaseDateAndTimeInputType.cpp

+++ b/Source/core/html/forms/BaseDateAndTimeInputType.cpp

@@ -90,11 +90,8 @@ String BaseDateAndTimeInputType::rangeUnderflowText(const Decimal& minimum) cons

Decimal BaseDateAndTimeInputType::defaultValueForStepUp() const

{

- double ms = currentTimeMS();

- double utcOffset = calculateUTCOffset();

- double dstOffset = calculateDSTOffset(ms, utcOffset);

- int offset = static_cast<int>((utcOffset + dstOffset) / msPerMinute);

- return Decimal::fromDouble(ms + (offset * msPerMinute));

+ double current = convertToLocalTime(currentTimeMS());

+ return Decimal::fromDouble(current);

tkent 2014/07/28 00:40:26 nit: return Decimal::fromDouble(convertToLocalTi

kangil_ 2014/07/31 00:45:45 Done.

}

bool BaseDateAndTimeInputType::isSteppable() const