Source/core/dom/Document.cpp - Issue 394903004: document.lastModified should consider user's local time zone

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Document.cpp

Issue 394903004: document.lastModified should consider user's local time zone (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix windows build error Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/http/tests/misc/last-modified-parsing.html ('K') | « LayoutTests/http/tests/resources/no-last-modified.php ('k') | Source/core/html/forms/BaseDateAndTimeInputType.cpp » ('j') | Source/core/html/forms/BaseDateAndTimeInputType.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/dom/Document.cpp

diff --git a/Source/core/dom/Document.cpp b/Source/core/dom/Document.cpp

index f328c474c2d9872d9b363ca33847a5a3a7a17903..aacaa20bd47abc10a137703ec8334bfc2ae27140 100644

--- a/Source/core/dom/Document.cpp

+++ b/Source/core/dom/Document.cpp

@@ -197,6 +197,7 @@

#include "platform/weborigin/SecurityOrigin.h"

#include "public/platform/Platform.h"

#include "wtf/CurrentTime.h"

+#include "wtf/DateMath.h"

#include "wtf/HashFunctions.h"

#include "wtf/MainThread.h"

#include "wtf/StdLibExtras.h"

@@ -4085,7 +4086,7 @@ String Document::lastModified() const

if (DocumentLoader* documentLoader = loader()) {

const AtomicString& httpLastModified = documentLoader->response().httpHeaderField("Last-Modified");

if (!httpLastModified.isEmpty()) {

- date.setMillisecondsSinceEpochForDateTime(parseDate(httpLastModified));

+ date.setMillisecondsSinceEpochForDateTime(convertToLocalTime(parseDate(httpLastModified)));

foundDate = true;

}

@@ -4094,7 +4095,7 @@ String Document::lastModified() const

// specificiation tells us to read the last modification date from the file

// system.

if (!foundDate)

- date.setMillisecondsSinceEpochForDateTime(currentTimeMS());

+ date.setMillisecondsSinceEpochForDateTime(convertToLocalTime(currentTimeMS()));

return String::format("%02d/%02d/%04d %02d:%02d:%02d", date.month() + 1, date.monthDay(), date.fullYear(), date.hour(), date.minute(), date.second());

}