Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 394523004: Revert of Don't treat first touch move differently from future touch moves (Closed)

Created:
6 years, 5 months ago by tdresser
Modified:
6 years, 5 months ago
Reviewers:
jdduke (slow), sadrul
CC:
aelias_OOO_until_Jul13, chromium-reviews, darin-cc_chromium.org, jam, Rick Byers
Visibility:
Public.

Description

Revert of Don't treat first touch move differently from future touch moves (https://codereview.chromium.org/228973003/) Reason for revert: This never set |seen_scroll_update_this_sequence_| to true, resulting in: https://code.google.com/p/chromium/issues/detail?id=393695 The fact that no tests caught this issue is pretty scary; we'll need some beefier tests as well as the trivial fix. Original issue's description: > Don't treat first move touch differently from future touch moves. > > See http://lists.w3.org/Archives/Public/public-touchevents/2014Apr/0005.html for details. > > BUG=354460 > TEST=TouchEventQueueTest.TouchAbsorptionWithConsumedFirstMove, TouchEventQueueTest.TouchCancelOnScroll > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282642 TBR=jdduke, sadrul Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283089

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -177 lines) Patch
M content/browser/renderer_host/input/touch_event_queue.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/renderer_host/input/touch_event_queue.cc View 2 chunks +19 lines, -26 lines 0 comments Download
M content/browser/renderer_host/input/touch_event_queue_unittest.cc View 8 chunks +6 lines, -81 lines 0 comments Download
M ui/aura/gestures/gesture_recognizer_unittest.cc View 8 chunks +16 lines, -55 lines 0 comments Download
M ui/events/gesture_detection/touch_disposition_gesture_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/gesture_detection/touch_disposition_gesture_filter_unittest.cc View 2 chunks +6 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tdresser
Created Revert of Don't treat first touch move differently from future touch moves
6 years, 5 months ago (2014-07-14 20:35:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdresser@chromium.org/394523004/1
6 years, 5 months ago (2014-07-14 20:37:29 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-14 20:37:30 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 5 months ago (2014-07-14 20:37:30 UTC) #4
tdresser
The CQ bit was checked by tdresser@chromium.org
6 years, 5 months ago (2014-07-14 20:44:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdresser@chromium.org/394523004/1
6 years, 5 months ago (2014-07-14 20:45:09 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-14 23:55:07 UTC) #7
Message was sent while issue was closed.
Change committed as 283089

Powered by Google App Engine
This is Rietveld 408576698