Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 394433002: Add :indeterminate pseudo class support for radio button input (Closed)

Created:
6 years, 5 months ago by keishi
Modified:
6 years, 1 month ago
Reviewers:
tkent
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Project:
blink
Visibility:
Public.

Description

Add :indeterminate pseudo class support for radio button input BUG=393827 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181227

Patch Set 1 #

Patch Set 2 : #

Total comments: 12

Patch Set 3 : #

Total comments: 8

Patch Set 4 : Fixed #

Total comments: 4

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -13 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/forms/radio/indeterminate-radio.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/radio/radio-appearance-basic.html View 1 2 1 chunk +2 lines, -1 line 0 comments Download
A LayoutTests/fast/forms/radio/radio-indeterminate-pseudo-class.html View 1 2 3 4 1 chunk +80 lines, -0 lines 0 comments Download
A LayoutTests/fast/forms/radio/radio-indeterminate-pseudo-class-expected.txt View 1 2 3 4 5 1 chunk +38 lines, -0 lines 0 comments Download
M Source/core/html/HTMLInputElement.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLInputElement.cpp View 1 2 3 2 chunks +4 lines, -2 lines 0 comments Download
M Source/core/html/forms/CheckboxInputType.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/CheckboxInputType.cpp View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/forms/InputType.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/InputType.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/RadioButtonGroupScope.cpp View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/html/forms/RadioInputType.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/RadioInputType.cpp View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/mac/ThemeMac.mm View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (3 generated)
keishi
6 years, 5 months ago (2014-07-14 11:41:09 UTC) #1
tkent
https://codereview.chromium.org/394433002/diff/20001/LayoutTests/fast/forms/radio/radio-indeterminate-pseudo-class.html File LayoutTests/fast/forms/radio/radio-indeterminate-pseudo-class.html (right): https://codereview.chromium.org/394433002/diff/20001/LayoutTests/fast/forms/radio/radio-indeterminate-pseudo-class.html#newcode36 LayoutTests/fast/forms/radio/radio-indeterminate-pseudo-class.html:36: debug('Changing checked should affect the matching of other buttons ...
6 years, 5 months ago (2014-07-15 01:31:50 UTC) #2
tkent
Would you file a bug for this please? It would be helpful for launch tracking ...
6 years, 5 months ago (2014-07-15 01:42:42 UTC) #3
keishi
https://codereview.chromium.org/394433002/diff/20001/LayoutTests/fast/forms/radio/radio-indeterminate-pseudo-class.html File LayoutTests/fast/forms/radio/radio-indeterminate-pseudo-class.html (right): https://codereview.chromium.org/394433002/diff/20001/LayoutTests/fast/forms/radio/radio-indeterminate-pseudo-class.html#newcode36 LayoutTests/fast/forms/radio/radio-indeterminate-pseudo-class.html:36: debug('Changing checked should affect the matching of other buttons ...
6 years, 5 months ago (2014-07-15 03:05:30 UTC) #4
tkent
https://codereview.chromium.org/394433002/diff/40001/LayoutTests/fast/forms/radio/radio-indeterminate-pseudo-class.html File LayoutTests/fast/forms/radio/radio-indeterminate-pseudo-class.html (right): https://codereview.chromium.org/394433002/diff/40001/LayoutTests/fast/forms/radio/radio-indeterminate-pseudo-class.html#newcode22 LayoutTests/fast/forms/radio/radio-indeterminate-pseudo-class.html:22: r1_1 = document.getElementById("r1_1"); Inconsistent quotes. Other lines have single ...
6 years, 4 months ago (2014-07-28 03:12:09 UTC) #5
keishi
https://codereview.chromium.org/394433002/diff/40001/LayoutTests/fast/forms/radio/radio-indeterminate-pseudo-class.html File LayoutTests/fast/forms/radio/radio-indeterminate-pseudo-class.html (right): https://codereview.chromium.org/394433002/diff/40001/LayoutTests/fast/forms/radio/radio-indeterminate-pseudo-class.html#newcode22 LayoutTests/fast/forms/radio/radio-indeterminate-pseudo-class.html:22: r1_1 = document.getElementById("r1_1"); On 2014/07/28 03:12:09, tkent wrote: > ...
6 years, 3 months ago (2014-09-02 03:49:54 UTC) #6
tkent
lgtm https://codereview.chromium.org/394433002/diff/60001/LayoutTests/fast/forms/radio/radio-indeterminate-pseudo-class.html File LayoutTests/fast/forms/radio/radio-indeterminate-pseudo-class.html (right): https://codereview.chromium.org/394433002/diff/60001/LayoutTests/fast/forms/radio/radio-indeterminate-pseudo-class.html#newcode64 LayoutTests/fast/forms/radio/radio-indeterminate-pseudo-class.html:64: r3_1.name = "r4"; inconsistent quotes https://codereview.chromium.org/394433002/diff/60001/LayoutTests/fast/forms/radio/radio-indeterminate-pseudo-class.html#newcode68 LayoutTests/fast/forms/radio/radio-indeterminate-pseudo-class.html:68: r3_1.name ...
6 years, 3 months ago (2014-09-02 03:55:37 UTC) #7
keishi
https://codereview.chromium.org/394433002/diff/60001/LayoutTests/fast/forms/radio/radio-indeterminate-pseudo-class.html File LayoutTests/fast/forms/radio/radio-indeterminate-pseudo-class.html (right): https://codereview.chromium.org/394433002/diff/60001/LayoutTests/fast/forms/radio/radio-indeterminate-pseudo-class.html#newcode64 LayoutTests/fast/forms/radio/radio-indeterminate-pseudo-class.html:64: r3_1.name = "r4"; On 2014/09/02 03:55:36, tkent wrote: > ...
6 years, 3 months ago (2014-09-02 03:58:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keishi@chromium.org/394433002/80001
6 years, 3 months ago (2014-09-02 03:59:17 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 3 months ago (2014-09-02 05:03:17 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/23002)
6 years, 3 months ago (2014-09-02 05:33:01 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keishi@chromium.org/394433002/100001
6 years, 3 months ago (2014-09-02 08:44:37 UTC) #15
commit-bot: I haz the power
Committed patchset #6 (id:100001) as 181227
6 years, 3 months ago (2014-09-02 09:46:53 UTC) #16
shreeramk
6 years, 1 month ago (2014-11-12 10:36:05 UTC) #17
Message was sent while issue was closed. 
On 2014/09/02 09:46:53, I haz the power (commit-bot) wrote:
> Committed patchset #6 (id:100001) as 181227

Following CL https://codereview.chromium.org/394433002 introduced a side effect
in accessibility.

HTML Content:
<html>
   <body>
     <input type="radio">
     <input type="radio" checked>
   </body>
</html>

AX Tree: For the case, when the input type radio is not checked,
STATE_SYSTEM_MIXED is getting exposed for input type radio.(which is wrong)

ROLE_SYSTEM_DOCUMENT READONLY FOCUSABLE
    IA2_ROLE_SECTION
        ROLE_SYSTEM_RADIOBUTTON MIXED FOCUSABLE IA2_STATE_CHECKABLE
checkable:true
        ROLE_SYSTEM_RADIOBUTTON CHECKED FOCUSABLE IA2_STATE_CHECKABLE
checkable:true

Powered by Google App Engine
This is Rietveld 408576698