chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h - Issue 394403003: Close the password bubble on the icon click.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h

Issue 394403003: Close the password bubble on the icon click. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Added a test Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h

diff --git a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h

index c24d747417574a32ba99533ad1efccf572829799..12cd886fa8111018b32658718f5e5d08d02c095b 100644

--- a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h

+++ b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h

@@ -141,6 +141,9 @@ class ManagePasswordsBubbleView : public ManagePasswordsBubble,

// Returns a pointer to the bubble.

static const ManagePasswordsBubbleView* Bubble();

+ // Returns the web content for the bubble.

Peter Kasting 2014/07/22 18:55:18 Nit: content -> contents

+ content::WebContents* web_contents() const;

Peter Kasting 2014/07/22 18:55:18 Const methods should not return non-const pointers

private:

ManagePasswordsBubbleView(content::WebContents* web_contents,

ManagePasswordsIconView* anchor_view,