Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Side by Side Diff: chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h

Issue 394403003: Close the password bubble on the icon click. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Added a test Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_PASSWORDS_MANAGE_PASSWORDS_BUBBLE_VIEW_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_PASSWORDS_MANAGE_PASSWORDS_BUBBLE_VIEW_H_
6 #define CHROME_BROWSER_UI_VIEWS_PASSWORDS_MANAGE_PASSWORDS_BUBBLE_VIEW_H_ 6 #define CHROME_BROWSER_UI_VIEWS_PASSWORDS_MANAGE_PASSWORDS_BUBBLE_VIEW_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "chrome/browser/ui/passwords/manage_passwords_bubble.h" 9 #include "chrome/browser/ui/passwords/manage_passwords_bubble.h"
10 #include "chrome/browser/ui/views/passwords/save_password_refusal_combobox_model .h" 10 #include "chrome/browser/ui/views/passwords/save_password_refusal_combobox_model .h"
(...skipping 123 matching lines...) Expand 10 before | Expand all | Expand 10 after
134 134
135 // Closes any existing bubble. 135 // Closes any existing bubble.
136 static void CloseBubble(); 136 static void CloseBubble();
137 137
138 // Whether the bubble is currently showing. 138 // Whether the bubble is currently showing.
139 static bool IsShowing(); 139 static bool IsShowing();
140 140
141 // Returns a pointer to the bubble. 141 // Returns a pointer to the bubble.
142 static const ManagePasswordsBubbleView* Bubble(); 142 static const ManagePasswordsBubbleView* Bubble();
143 143
144 // Returns the web content for the bubble.
Peter Kasting 2014/07/22 18:55:18 Nit: content -> contents
145 content::WebContents* web_contents() const;
Peter Kasting 2014/07/22 18:55:18 Const methods should not return non-const pointers
146
144 private: 147 private:
145 ManagePasswordsBubbleView(content::WebContents* web_contents, 148 ManagePasswordsBubbleView(content::WebContents* web_contents,
146 ManagePasswordsIconView* anchor_view, 149 ManagePasswordsIconView* anchor_view,
147 DisplayReason reason); 150 DisplayReason reason);
148 virtual ~ManagePasswordsBubbleView(); 151 virtual ~ManagePasswordsBubbleView();
149 152
150 // If the bubble is not anchored to a view, places the bubble in the top 153 // If the bubble is not anchored to a view, places the bubble in the top
151 // right (left in RTL) of the |screen_bounds| that contain |web_contents_|'s 154 // right (left in RTL) of the |screen_bounds| that contain |web_contents_|'s
152 // browser window. Because the positioning is based on the size of the 155 // browser window. Because the positioning is based on the size of the
153 // bubble, this must be called after the bubble is created. 156 // bubble, this must be called after the bubble is created.
(...skipping 30 matching lines...) Expand all
184 ManagePasswordsIconView* anchor_view_; 187 ManagePasswordsIconView* anchor_view_;
185 188
186 // If true upon destruction, the user has confirmed that she never wants to 189 // If true upon destruction, the user has confirmed that she never wants to
187 // save passwords for a particular site. 190 // save passwords for a particular site.
188 bool never_save_passwords_; 191 bool never_save_passwords_;
189 192
190 DISALLOW_COPY_AND_ASSIGN(ManagePasswordsBubbleView); 193 DISALLOW_COPY_AND_ASSIGN(ManagePasswordsBubbleView);
191 }; 194 };
192 195
193 #endif // CHROME_BROWSER_UI_VIEWS_PASSWORDS_MANAGE_PASSWORDS_BUBBLE_VIEW_H_ 196 #endif // CHROME_BROWSER_UI_VIEWS_PASSWORDS_MANAGE_PASSWORDS_BUBBLE_VIEW_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698