chrome/browser/ui/views/location_bar/bubble_icon_view.cc - Issue 394403003: Close the password bubble on the icon click.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/bubble_icon_view.cc

Issue 394403003: Close the password bubble on the icon click. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Added a test Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/location_bar/bubble_icon_view.cc

diff --git a/chrome/browser/ui/views/location_bar/bubble_icon_view.cc b/chrome/browser/ui/views/location_bar/bubble_icon_view.cc

index 68949b4b160a48130c4fb31599daf7028c4684b2..ba1680154258501b5ddcf476771de242f6214ae1 100644

--- a/chrome/browser/ui/views/location_bar/bubble_icon_view.cc

+++ b/chrome/browser/ui/views/location_bar/bubble_icon_view.cc

@@ -34,6 +34,8 @@ bool BubbleIconView::GetTooltipText(const gfx::Point& p,

bool BubbleIconView::OnMousePressed(const ui::MouseEvent& event) {

// If the bubble is showing then don't reshow it when the mouse is released.

suppress_mouse_released_action_ = IsBubbleShowing();

+ if (suppress_mouse_released_action_)

+ OnMousePressSuppressed();

// We want to show the bubble on mouse release; that is the standard behavior

// for buttons.