Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4255)

Unified Diff: chrome/browser/ui/views/location_bar/bubble_icon_view.cc

Issue 394403003: Close the password bubble on the icon click. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Removed the unnecessary command Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/location_bar/bubble_icon_view.cc
diff --git a/chrome/browser/ui/views/location_bar/bubble_icon_view.cc b/chrome/browser/ui/views/location_bar/bubble_icon_view.cc
index 68949b4b160a48130c4fb31599daf7028c4684b2..c314f004408df3368c5d755b7e4b8ea375a150ce 100644
--- a/chrome/browser/ui/views/location_bar/bubble_icon_view.cc
+++ b/chrome/browser/ui/views/location_bar/bubble_icon_view.cc
@@ -34,6 +34,8 @@ bool BubbleIconView::GetTooltipText(const gfx::Point& p,
bool BubbleIconView::OnMousePressed(const ui::MouseEvent& event) {
// If the bubble is showing then don't reshow it when the mouse is released.
suppress_mouse_released_action_ = IsBubbleShowing();
+ if (suppress_mouse_released_action_)
+ OnMousePressedIgnored();
Mike West 2014/07/22 12:08:40 Is the timing of this call important? If not, it s
vasilii 2014/07/22 14:18:51 All other bubbles lose the focus on mouse down eve
Mike West 2014/07/22 14:23:47 Hrm. *shrug* Either way. If this is consistent wit
// We want to show the bubble on mouse release; that is the standard behavior
// for buttons.

Powered by Google App Engine
This is Rietveld 408576698