Close the password bubble on the icon click.

chrome/browser/ui/views/location_bar/bubble_icon_view.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/location_bar/bubble_icon_view.h"
 
 #include "chrome/browser/command_updater.h"
 #include "ui/accessibility/ax_view_state.h"
 #include "ui/events/event.h"
 
@@ skipping 16 matching lines @@
                                     base::string16* tooltip) const {
   if (IsBubbleShowing())
     return false;
 
   return views::ImageView::GetTooltipText(p, tooltip);
 }
 
 bool BubbleIconView::OnMousePressed(const ui::MouseEvent& event) {
   // If the bubble is showing then don't reshow it when the mouse is released.
   suppress_mouse_released_action_ = IsBubbleShowing();
+  if (suppress_mouse_released_action_)
+    OnMousePressedIgnored();

[Mike West, 2014/07/22 12:08:40]

Is the timing of this call important? If not, it seems reasonable to move it
down to '::OnMouseReleased()' (and rename it accordingly).

[vasilii, 2014/07/22 14:18:51]

All other bubbles lose the focus on mouse down event. Otherwise some interesting
questions occur. If you click the icon, move the cursor outside of Chrome and
release then do we want to close the bubble?

[Mike West, 2014/07/22 14:23:47]

Hrm. *shrug* Either way. If this is consistent with other bubbles, that's great.

 
   // We want to show the bubble on mouse release; that is the standard behavior
   // for buttons.
   return true;
 }
 
 void BubbleIconView::OnMouseReleased(const ui::MouseEvent& event) {
   // If this is the second click on this view then the bubble was showing on the
   // mouse pressed event and is hidden now. Prevent the bubble from reshowing by
   // doing nothing here.
@@ skipping 18 matching lines @@
   return false;
 }
 
 void BubbleIconView::OnGestureEvent(ui::GestureEvent* event) {
   if (event->type() == ui::ET_GESTURE_TAP) {
     OnExecuting(EXECUTE_SOURCE_GESTURE);
     command_updater_->ExecuteCommand(command_id_);
     event->SetHandled();
   }
 }