Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2038)

Unified Diff: chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc

Issue 394403003: Close the password bubble on the icon click. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rename the getter Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
diff --git a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
index 356919e43c008c9ec0c899d2b20ca244aa3204db..d6afd6257459fb1671e0400361f261c32fab8f2a 100644
--- a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
+++ b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
@@ -126,6 +126,11 @@ void AddTitleRow(views::GridLayout* layout, ManagePasswordsBubbleModel* model) {
namespace chrome {
void ShowManagePasswordsBubble(content::WebContents* web_contents) {
+ if (ManagePasswordsBubbleView::IsShowing()) {
+ // The bubble is currently shown for some other tab. We should close it now
+ // and open for |web_contents|.
+ ManagePasswordsBubbleView::CloseBubble();
+ }
ManagePasswordsUIController* controller =
ManagePasswordsUIController::FromWebContents(web_contents);
ManagePasswordsBubbleView::ShowBubble(
@@ -434,11 +439,6 @@ ManagePasswordsBubbleView* ManagePasswordsBubbleView::manage_passwords_bubble_ =
NULL;
// static
-const ManagePasswordsBubbleView* ManagePasswordsBubbleView::Bubble() {
- return ManagePasswordsBubbleView::manage_passwords_bubble_;
-}
-
-// static
void ManagePasswordsBubbleView::ShowBubble(content::WebContents* web_contents,
DisplayReason reason) {
Browser* browser = chrome::FindBrowserWithWebContents(web_contents);

Powered by Google App Engine
This is Rietveld 408576698