chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc - Issue 394403003: Close the password bubble on the icon click.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc

Issue 394403003: Close the password bubble on the icon click. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rename the getter Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc ('k') | chrome/browser/ui/views/passwords/manage_passwords_icon_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc

diff --git a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc

index 09eb0107a087e7dc890766cc8e4a6c554eb0ee4b..cceeb7057e3ddd330fd0c3a0e6ffa286e004e003 100644

--- a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc

+++ b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc

@@ -81,10 +81,11 @@ IN_PROC_BROWSER_TEST_F(ManagePasswordsBubbleViewTest,

SetupPendingPassword();

// Bubble should not be focused by default.

- EXPECT_FALSE(

- ManagePasswordsBubbleView::Bubble()->GetFocusManager()->GetFocusedView());

+ EXPECT_FALSE(ManagePasswordsBubbleView::manage_password_bubble()->

+ GetFocusManager()->GetFocusedView());

// Bubble can be active if user clicks it.

- EXPECT_TRUE(ManagePasswordsBubbleView::Bubble()->CanActivate());

+ EXPECT_TRUE(ManagePasswordsBubbleView::manage_password_bubble()->

+ CanActivate());

scoped_ptr<base::HistogramSamples> samples(

GetSamples(kDisplayDispositionMetric));