Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 394383002: Convert DLOG/DVLOG messages in chrome.dial to VLOG. (Closed)

Created:
6 years, 5 months ago by mark a. foltz
Modified:
6 years, 5 months ago
Reviewers:
Wez
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Convert DLOG/DVLOG messages in chrome.dial to VLOG. Messages which track the progress of discovery are VLOG(2) and unusual events are VLOG(1). We can use this to diagnose failures in test automation with release builds. BUG=394082 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283924

Patch Set 1 #

Total comments: 2

Patch Set 2 : Response to wez comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -24 lines) Patch
M chrome/browser/extensions/api/dial/dial_api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/dial/dial_registry.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/dial/dial_service.cc View 1 11 chunks +21 lines, -21 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
mark a. foltz
6 years, 5 months ago (2014-07-17 00:17:50 UTC) #1
Wez
lgtm https://codereview.chromium.org/394383002/diff/1/chrome/browser/extensions/api/dial/dial_service.cc File chrome/browser/extensions/api/dial/dial_service.cc (right): https://codereview.chromium.org/394383002/diff/1/chrome/browser/extensions/api/dial/dial_service.cc#newcode331 chrome/browser/extensions/api/dial/dial_service.cc:331: VLOG(2) << "raw_headers: " << raw_headers << "\n"; ...
6 years, 5 months ago (2014-07-17 00:39:01 UTC) #2
mark a. foltz
https://codereview.chromium.org/394383002/diff/1/chrome/browser/extensions/api/dial/dial_service.cc File chrome/browser/extensions/api/dial/dial_service.cc (right): https://codereview.chromium.org/394383002/diff/1/chrome/browser/extensions/api/dial/dial_service.cc#newcode331 chrome/browser/extensions/api/dial/dial_service.cc:331: VLOG(2) << "raw_headers: " << raw_headers << "\n"; On ...
6 years, 5 months ago (2014-07-17 18:33:20 UTC) #3
mark a. foltz
The CQ bit was checked by mfoltz@chromium.org
6 years, 5 months ago (2014-07-17 18:34:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mfoltz@chromium.org/394383002/20001
6 years, 5 months ago (2014-07-17 18:38:05 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-17 22:18:29 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 23:30:05 UTC) #7
Message was sent while issue was closed.
Change committed as 283924

Powered by Google App Engine
This is Rietveld 408576698