Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Side by Side Diff: chrome/browser/extensions/api/dial/dial_service.cc

Issue 394383002: Convert DLOG/DVLOG messages in chrome.dial to VLOG. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Response to wez comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/extensions/api/dial/dial_registry.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/api/dial/dial_service.h" 5 #include "chrome/browser/extensions/api/dial/dial_service.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <set> 8 #include <set>
9 #include <utility> 9 #include <utility>
10 10
(...skipping 99 matching lines...) Expand 10 before | Expand all | Expand 10 after
110 } 110 }
111 111
112 #if !defined(OS_CHROMEOS) 112 #if !defined(OS_CHROMEOS)
113 void GetNetworkListOnFileThread( 113 void GetNetworkListOnFileThread(
114 const scoped_refptr<base::MessageLoopProxy>& loop, 114 const scoped_refptr<base::MessageLoopProxy>& loop,
115 const base::Callback<void(const NetworkInterfaceList& networks)>& cb) { 115 const base::Callback<void(const NetworkInterfaceList& networks)>& cb) {
116 NetworkInterfaceList list; 116 NetworkInterfaceList list;
117 bool success = net::GetNetworkList( 117 bool success = net::GetNetworkList(
118 &list, net::INCLUDE_HOST_SCOPE_VIRTUAL_INTERFACES); 118 &list, net::INCLUDE_HOST_SCOPE_VIRTUAL_INTERFACES);
119 if (!success) 119 if (!success)
120 DVLOG(1) << "Could not retrieve network list!"; 120 VLOG(1) << "Could not retrieve network list!";
121 121
122 loop->PostTask(FROM_HERE, base::Bind(cb, list)); 122 loop->PostTask(FROM_HERE, base::Bind(cb, list));
123 } 123 }
124 124
125 #else 125 #else
126 126
127 // Finds the IP address of the preferred interface of network type |type| 127 // Finds the IP address of the preferred interface of network type |type|
128 // to bind the socket and inserts the address into |bind_address_list|. This 128 // to bind the socket and inserts the address into |bind_address_list|. This
129 // ChromeOS version can prioritize wifi and ethernet interfaces. 129 // ChromeOS version can prioritize wifi and ethernet interfaces.
130 void InsertBestBindAddressChromeOS( 130 void InsertBestBindAddressChromeOS(
131 const chromeos::NetworkTypePattern& type, 131 const chromeos::NetworkTypePattern& type,
132 std::vector<IPAddressNumber>* bind_address_list) { 132 std::vector<IPAddressNumber>* bind_address_list) {
133 const chromeos::NetworkState* state = chromeos::NetworkHandler::Get() 133 const chromeos::NetworkState* state = chromeos::NetworkHandler::Get()
134 ->network_state_handler()->ConnectedNetworkByType(type); 134 ->network_state_handler()->ConnectedNetworkByType(type);
135 IPAddressNumber bind_ip_address; 135 IPAddressNumber bind_ip_address;
136 if (state 136 if (state
137 && net::ParseIPLiteralToNumber(state->ip_address(), &bind_ip_address) 137 && net::ParseIPLiteralToNumber(state->ip_address(), &bind_ip_address)
138 && bind_ip_address.size() == net::kIPv4AddressSize) { 138 && bind_ip_address.size() == net::kIPv4AddressSize) {
139 DVLOG(1) << "Found " << state->type() << ", " << state->name() << ": " 139 VLOG(2) << "Found " << state->type() << ", " << state->name() << ": "
140 << state->ip_address(); 140 << state->ip_address();
141 bind_address_list->push_back(bind_ip_address); 141 bind_address_list->push_back(bind_ip_address);
142 } 142 }
143 } 143 }
144 #endif // !defined(OS_CHROMEOS) 144 #endif // !defined(OS_CHROMEOS)
145 145
146 } // namespace 146 } // namespace
147 147
148 DialServiceImpl::DialSocket::DialSocket( 148 DialServiceImpl::DialSocket::DialSocket(
149 const base::Closure& discovery_request_cb, 149 const base::Closure& discovery_request_cb,
150 const base::Callback<void(const DialDeviceData&)>& device_discovered_cb, 150 const base::Callback<void(const DialDeviceData&)>& device_discovered_cb,
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
184 DCHECK(socket_.get()); 184 DCHECK(socket_.get());
185 185
186 recv_buffer_ = new IOBufferWithSize(kDialRecvBufferSize); 186 recv_buffer_ = new IOBufferWithSize(kDialRecvBufferSize);
187 return ReadSocket(); 187 return ReadSocket();
188 } 188 }
189 189
190 void DialServiceImpl::DialSocket::SendOneRequest( 190 void DialServiceImpl::DialSocket::SendOneRequest(
191 const net::IPEndPoint& send_address, 191 const net::IPEndPoint& send_address,
192 const scoped_refptr<net::StringIOBuffer>& send_buffer) { 192 const scoped_refptr<net::StringIOBuffer>& send_buffer) {
193 if (!socket_.get()) { 193 if (!socket_.get()) {
194 DLOG(WARNING) << "Socket not connected."; 194 VLOG(1) << "Socket not connected.";
195 return; 195 return;
196 } 196 }
197 197
198 if (is_writing_) { 198 if (is_writing_) {
199 VLOG(2) << "Already writing."; 199 VLOG(1) << "Already writing.";
200 return; 200 return;
201 } 201 }
202 202
203 is_writing_ = true; 203 is_writing_ = true;
204 int result = socket_->SendTo( 204 int result = socket_->SendTo(
205 send_buffer.get(), send_buffer->size(), send_address, 205 send_buffer.get(), send_buffer->size(), send_address,
206 base::Bind(&DialServiceImpl::DialSocket::OnSocketWrite, 206 base::Bind(&DialServiceImpl::DialSocket::OnSocketWrite,
207 base::Unretained(this), 207 base::Unretained(this),
208 send_buffer->size())); 208 send_buffer->size()));
209 bool result_ok = CheckResult("SendTo", result); 209 bool result_ok = CheckResult("SendTo", result);
210 if (result_ok && result > 0) { 210 if (result_ok && result > 0) {
211 // Synchronous write. 211 // Synchronous write.
212 OnSocketWrite(send_buffer->size(), result); 212 OnSocketWrite(send_buffer->size(), result);
213 } 213 }
214 } 214 }
215 215
216 bool DialServiceImpl::DialSocket::IsClosed() { 216 bool DialServiceImpl::DialSocket::IsClosed() {
217 DCHECK(thread_checker_.CalledOnValidThread()); 217 DCHECK(thread_checker_.CalledOnValidThread());
218 return !socket_.get(); 218 return !socket_.get();
219 } 219 }
220 220
221 bool DialServiceImpl::DialSocket::CheckResult(const char* operation, 221 bool DialServiceImpl::DialSocket::CheckResult(const char* operation,
222 int result) { 222 int result) {
223 DCHECK(thread_checker_.CalledOnValidThread()); 223 DCHECK(thread_checker_.CalledOnValidThread());
224 VLOG(2) << "Operation " << operation << " result " << result; 224 VLOG(2) << "Operation " << operation << " result " << result;
225 if (result < net::OK && result != net::ERR_IO_PENDING) { 225 if (result < net::OK && result != net::ERR_IO_PENDING) {
226 Close(); 226 Close();
227 std::string error_str(net::ErrorToString(result)); 227 std::string error_str(net::ErrorToString(result));
228 DVLOG(0) << "dial socket error: " << error_str; 228 VLOG(1) << "dial socket error: " << error_str;
229 on_error_cb_.Run(); 229 on_error_cb_.Run();
230 return false; 230 return false;
231 } 231 }
232 return true; 232 return true;
233 } 233 }
234 234
235 void DialServiceImpl::DialSocket::Close() { 235 void DialServiceImpl::DialSocket::Close() {
236 DCHECK(thread_checker_.CalledOnValidThread()); 236 DCHECK(thread_checker_.CalledOnValidThread());
237 is_reading_ = false; 237 is_reading_ = false;
238 is_writing_ = false; 238 is_writing_ = false;
239 socket_.reset(); 239 socket_.reset();
240 } 240 }
241 241
242 void DialServiceImpl::DialSocket::OnSocketWrite(int send_buffer_size, 242 void DialServiceImpl::DialSocket::OnSocketWrite(int send_buffer_size,
243 int result) { 243 int result) {
244 DCHECK(thread_checker_.CalledOnValidThread()); 244 DCHECK(thread_checker_.CalledOnValidThread());
245 is_writing_ = false; 245 is_writing_ = false;
246 if (!CheckResult("OnSocketWrite", result)) 246 if (!CheckResult("OnSocketWrite", result))
247 return; 247 return;
248 if (result != send_buffer_size) { 248 if (result != send_buffer_size) {
249 DLOG(ERROR) << "Sent " << result << " chars, expected " 249 VLOG(1) << "Sent " << result << " chars, expected "
250 << send_buffer_size << " chars"; 250 << send_buffer_size << " chars";
251 } 251 }
252 discovery_request_cb_.Run(); 252 discovery_request_cb_.Run();
253 } 253 }
254 254
255 bool DialServiceImpl::DialSocket::ReadSocket() { 255 bool DialServiceImpl::DialSocket::ReadSocket() {
256 DCHECK(thread_checker_.CalledOnValidThread()); 256 DCHECK(thread_checker_.CalledOnValidThread());
257 if (!socket_.get()) { 257 if (!socket_.get()) {
258 DLOG(WARNING) << "Socket not connected."; 258 VLOG(1) << "Socket not connected.";
259 return false; 259 return false;
260 } 260 }
261 261
262 if (is_reading_) { 262 if (is_reading_) {
263 VLOG(2) << "Already reading."; 263 VLOG(1) << "Already reading.";
264 return false; 264 return false;
265 } 265 }
266 266
267 int result = net::OK; 267 int result = net::OK;
268 bool result_ok = true; 268 bool result_ok = true;
269 do { 269 do {
270 is_reading_ = true; 270 is_reading_ = true;
271 result = socket_->RecvFrom( 271 result = socket_->RecvFrom(
272 recv_buffer_.get(), 272 recv_buffer_.get(),
273 kDialRecvBufferSize, &recv_address_, 273 kDialRecvBufferSize, &recv_address_,
(...skipping 19 matching lines...) Expand all
293 HandleResponse(result); 293 HandleResponse(result);
294 294
295 // Await next response. 295 // Await next response.
296 ReadSocket(); 296 ReadSocket();
297 } 297 }
298 298
299 void DialServiceImpl::DialSocket::HandleResponse(int bytes_read) { 299 void DialServiceImpl::DialSocket::HandleResponse(int bytes_read) {
300 DCHECK(thread_checker_.CalledOnValidThread()); 300 DCHECK(thread_checker_.CalledOnValidThread());
301 DCHECK_GT(bytes_read, 0); 301 DCHECK_GT(bytes_read, 0);
302 if (bytes_read > kDialRecvBufferSize) { 302 if (bytes_read > kDialRecvBufferSize) {
303 DLOG(ERROR) << bytes_read << " > " << kDialRecvBufferSize << "!?"; 303 VLOG(1) << bytes_read << " > " << kDialRecvBufferSize << "!?";
304 return; 304 return;
305 } 305 }
306 VLOG(2) << "Read " << bytes_read << " bytes from " 306 VLOG(2) << "Read " << bytes_read << " bytes from "
307 << recv_address_.ToString(); 307 << recv_address_.ToString();
308 308
309 std::string response(recv_buffer_->data(), bytes_read); 309 std::string response(recv_buffer_->data(), bytes_read);
310 Time response_time = Time::Now(); 310 Time response_time = Time::Now();
311 311
312 // Attempt to parse response, notify observers if successful. 312 // Attempt to parse response, notify observers if successful.
313 DialDeviceData parsed_device; 313 DialDeviceData parsed_device;
314 if (ParseResponse(response, response_time, &parsed_device)) 314 if (ParseResponse(response, response_time, &parsed_device))
315 device_discovered_cb_.Run(parsed_device); 315 device_discovered_cb_.Run(parsed_device);
316 } 316 }
317 317
318 // static 318 // static
319 bool DialServiceImpl::DialSocket::ParseResponse( 319 bool DialServiceImpl::DialSocket::ParseResponse(
320 const std::string& response, 320 const std::string& response,
321 const base::Time& response_time, 321 const base::Time& response_time,
322 DialDeviceData* device) { 322 DialDeviceData* device) {
323 int headers_end = HttpUtil::LocateEndOfHeaders(response.c_str(), 323 int headers_end = HttpUtil::LocateEndOfHeaders(response.c_str(),
324 response.size()); 324 response.size());
325 if (headers_end < 1) { 325 if (headers_end < 1) {
326 VLOG(2) << "Headers invalid or empty, ignoring: " << response; 326 VLOG(1) << "Headers invalid or empty, ignoring: " << response;
327 return false; 327 return false;
328 } 328 }
329 std::string raw_headers = 329 std::string raw_headers =
330 HttpUtil::AssembleRawHeaders(response.c_str(), headers_end); 330 HttpUtil::AssembleRawHeaders(response.c_str(), headers_end);
331 VLOG(2) << "raw_headers: " << raw_headers << "\n"; 331 VLOG(3) << "raw_headers: " << raw_headers << "\n";
332 scoped_refptr<HttpResponseHeaders> headers = 332 scoped_refptr<HttpResponseHeaders> headers =
333 new HttpResponseHeaders(raw_headers); 333 new HttpResponseHeaders(raw_headers);
334 334
335 std::string device_url_str; 335 std::string device_url_str;
336 if (!GetHeader(headers.get(), kSsdpLocationHeader, &device_url_str) || 336 if (!GetHeader(headers.get(), kSsdpLocationHeader, &device_url_str) ||
337 device_url_str.empty()) { 337 device_url_str.empty()) {
338 VLOG(2) << "No LOCATION header found."; 338 VLOG(1) << "No LOCATION header found.";
339 return false; 339 return false;
340 } 340 }
341 341
342 GURL device_url(device_url_str); 342 GURL device_url(device_url_str);
343 if (!DialDeviceData::IsDeviceDescriptionUrl(device_url)) { 343 if (!DialDeviceData::IsDeviceDescriptionUrl(device_url)) {
344 VLOG(2) << "URL " << device_url_str << " not valid."; 344 VLOG(1) << "URL " << device_url_str << " not valid.";
345 return false; 345 return false;
346 } 346 }
347 347
348 std::string device_id; 348 std::string device_id;
349 if (!GetHeader(headers.get(), kSsdpUsnHeader, &device_id) || 349 if (!GetHeader(headers.get(), kSsdpUsnHeader, &device_id) ||
350 device_id.empty()) { 350 device_id.empty()) {
351 VLOG(2) << "No USN header found."; 351 VLOG(1) << "No USN header found.";
352 return false; 352 return false;
353 } 353 }
354 354
355 device->set_device_id(device_id); 355 device->set_device_id(device_id);
356 device->set_device_description_url(device_url); 356 device->set_device_description_url(device_url);
357 device->set_response_time(response_time); 357 device->set_response_time(response_time);
358 358
359 // TODO(mfoltz): Parse the max-age value from the cache control header. 359 // TODO(mfoltz): Parse the max-age value from the cache control header.
360 // http://crbug.com/165289 360 // http://crbug.com/165289
361 std::string cache_control; 361 std::string cache_control;
362 GetHeader(headers.get(), kSsdpCacheControlHeader, &cache_control); 362 GetHeader(headers.get(), kSsdpCacheControlHeader, &cache_control);
363 363
364 std::string config_id; 364 std::string config_id;
365 int config_id_int; 365 int config_id_int;
366 if (GetHeader(headers.get(), kSsdpConfigIdHeader, &config_id) && 366 if (GetHeader(headers.get(), kSsdpConfigIdHeader, &config_id) &&
367 base::StringToInt(config_id, &config_id_int)) { 367 base::StringToInt(config_id, &config_id_int)) {
368 device->set_config_id(config_id_int); 368 device->set_config_id(config_id_int);
369 } else { 369 } else {
370 VLOG(2) << "Malformed or missing " << kSsdpConfigIdHeader << ": " 370 VLOG(1) << "Malformed or missing " << kSsdpConfigIdHeader << ": "
371 << config_id; 371 << config_id;
372 } 372 }
373 373
374 return true; 374 return true;
375 } 375 }
376 376
377 DialServiceImpl::DialServiceImpl(net::NetLog* net_log) 377 DialServiceImpl::DialServiceImpl(net::NetLog* net_log)
378 : discovery_active_(false), 378 : discovery_active_(false),
379 num_requests_sent_(0), 379 num_requests_sent_(0),
380 max_requests_(kDialMaxRequests), 380 max_requests_(kDialMaxRequests),
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
459 std::set<InterfaceIndexAddressFamily> interface_index_addr_family_seen; 459 std::set<InterfaceIndexAddressFamily> interface_index_addr_family_seen;
460 std::vector<IPAddressNumber> ip_addresses; 460 std::vector<IPAddressNumber> ip_addresses;
461 461
462 // Binds a socket to each IPv4 network interface found. Note that 462 // Binds a socket to each IPv4 network interface found. Note that
463 // there may be duplicates in |networks|, so address family + interface index 463 // there may be duplicates in |networks|, so address family + interface index
464 // is used to identify unique interfaces. 464 // is used to identify unique interfaces.
465 // TODO(mfoltz): Support IPV6 multicast. http://crbug.com/165286 465 // TODO(mfoltz): Support IPV6 multicast. http://crbug.com/165286
466 for (NetworkInterfaceList::const_iterator iter = networks.begin(); 466 for (NetworkInterfaceList::const_iterator iter = networks.begin();
467 iter != networks.end(); ++iter) { 467 iter != networks.end(); ++iter) {
468 net::AddressFamily addr_family = net::GetAddressFamily(iter->address); 468 net::AddressFamily addr_family = net::GetAddressFamily(iter->address);
469 DVLOG(1) << "Found " << iter->name << ", " 469 VLOG(2) << "Found " << iter->name << ", "
470 << net::IPAddressToString(iter->address) 470 << net::IPAddressToString(iter->address)
471 << ", address family: " << addr_family; 471 << ", address family: " << addr_family;
472 if (addr_family == net::ADDRESS_FAMILY_IPV4) { 472 if (addr_family == net::ADDRESS_FAMILY_IPV4) {
473 InterfaceIndexAddressFamily interface_index_addr_family = 473 InterfaceIndexAddressFamily interface_index_addr_family =
474 std::make_pair(iter->interface_index, addr_family); 474 std::make_pair(iter->interface_index, addr_family);
475 bool inserted = interface_index_addr_family_seen 475 bool inserted = interface_index_addr_family_seen
476 .insert(interface_index_addr_family) 476 .insert(interface_index_addr_family)
477 .second; 477 .second;
478 // We have not seen this interface before, so add its IP address to the 478 // We have not seen this interface before, so add its IP address to the
479 // discovery list. 479 // discovery list.
480 if (inserted) { 480 if (inserted) {
481 VLOG(2) << "Encountered " 481 VLOG(2) << "Encountered "
482 << "interface index: " << iter->interface_index << ", " 482 << "interface index: " << iter->interface_index << ", "
483 << "address family: " << addr_family << " for the first time, " 483 << "address family: " << addr_family << " for the first time, "
484 << "adding IP address " << net::IPAddressToString(iter->address) 484 << "adding IP address " << net::IPAddressToString(iter->address)
485 << " to list."; 485 << " to list.";
486 ip_addresses.push_back(iter->address); 486 ip_addresses.push_back(iter->address);
487 } else { 487 } else {
488 VLOG(2) << "Already encountered " 488 VLOG(2) << "Already encountered "
489 << "interface index: " << iter->interface_index << ", " 489 << "interface index: " << iter->interface_index << ", "
490 << "address family: " << addr_family << " before, not adding."; 490 << "address family: " << addr_family << " before, not adding.";
491 } 491 }
492 } 492 }
493 } 493 }
494 494
495 DiscoverOnAddresses(ip_addresses); 495 DiscoverOnAddresses(ip_addresses);
496 } 496 }
497 497
498 void DialServiceImpl::DiscoverOnAddresses( 498 void DialServiceImpl::DiscoverOnAddresses(
499 const std::vector<IPAddressNumber>& ip_addresses) { 499 const std::vector<IPAddressNumber>& ip_addresses) {
500 if (ip_addresses.empty()) { 500 if (ip_addresses.empty()) {
501 DVLOG(1) << "Could not find a valid interface to bind. Finishing discovery"; 501 VLOG(1) << "Could not find a valid interface to bind. Finishing discovery";
502 FinishDiscovery(); 502 FinishDiscovery();
503 return; 503 return;
504 } 504 }
505 505
506 // Schedule a timer to finish the discovery process (and close the sockets). 506 // Schedule a timer to finish the discovery process (and close the sockets).
507 if (finish_delay_ > TimeDelta::FromSeconds(0)) { 507 if (finish_delay_ > TimeDelta::FromSeconds(0)) {
508 VLOG(2) << "Starting timer to finish discovery."; 508 VLOG(2) << "Starting timer to finish discovery.";
509 finish_timer_.Start(FROM_HERE, 509 finish_timer_.Start(FROM_HERE,
510 finish_delay_, 510 finish_delay_,
511 this, 511 this,
(...skipping 103 matching lines...) Expand 10 before | Expand all | Expand 10 after
615 for (ScopedVector<DialSocket>::const_iterator iter = dial_sockets_.begin(); 615 for (ScopedVector<DialSocket>::const_iterator iter = dial_sockets_.begin();
616 iter != dial_sockets_.end(); 616 iter != dial_sockets_.end();
617 ++iter) { 617 ++iter) {
618 if (!((*iter)->IsClosed())) 618 if (!((*iter)->IsClosed()))
619 return true; 619 return true;
620 } 620 }
621 return false; 621 return false;
622 } 622 }
623 623
624 } // namespace extensions 624 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/browser/extensions/api/dial/dial_registry.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698