Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 394353002: Replace tests of ASSERT_ENABLED with ENABLE(ASSERT). (Closed)

Created:
6 years, 5 months ago by Ken Russell (switch to Gerrit)
Modified:
6 years, 5 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, aandrey+blink_chromium.org, darktears, apavlov+blink_chromium.org, arv+blink, blink-layers+watch_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-bindings_chromium.org, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, blink-reviews-rendering, blink-reviews-wtf_chromium.org, Rik, caseq+blink_chromium.org, danakj, devtools-reviews_chromium.org, dglazkov+blink, krit, dstockwell, eae+blinkwatch, ed+blinkwatch_opera.com, eric.carlson_apple.com, Eric Willigers, eseidel, eustas+blink_chromium.org, feature-media-reviews_chromium.org, f(malita), fs, gavinp+loader_chromium.org, groby+blinkspell_chromium.org, gyuyoung.kim_webkit.org, jamesr, Nate Chapin, jbroman, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, loislo+blink_chromium.org, lushnikov+blink_chromium.org, malch+blink_chromium.org, Mike Lawther (Google), Mikhail, paulirish+reviews_chromium.org, pdr., pfeldman+blink_chromium.org, philipj_slow, rjwright, rwlbuis, Raymond Toy, rune+blink, Stephen Chennney, sergeyv+blink_chromium.org, shans, sof, Steve Block, Timothy Loh, vsevik+blink_chromium.org, yurys+blink_chromium.org, zoltan1
Project:
blink
Visibility:
Public.

Description

Replace tests of ASSERT_ENABLED with ENABLE(ASSERT). Also replaced tests of SECURITY_ASSERT_ENABLED with ENABLE(SECURITY_ASSERT). This change helps ensure that Assertions.h has been properly included, and paves the way toward enabling asserts in Release builds of Blink. This is almost completely a search-and-replace operation. The only exceptions are Image.h, where previous work indicated an #include of Assertions.h was needed; RawResource.h, which contained an incorrect use of SECURITY_ASSERT_ENABLED; and Assertions.h, which has been converted to define ENABLE_ASSERT instead of ASSERT_ENABLED and similar for the security assert. Tested with a debug build of Chromium and verified that a manually inserted failure under ENABLE(ASSERT) was triggered. BUG=393838 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178303

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+198 lines, -193 lines) Patch
M Source/bindings/core/v8/ExceptionStatePlaceholder.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/ExceptionStatePlaceholder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/ScriptPromiseResolver.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/ScriptPromiseResolver.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/css/CSSAnimations.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSStyleSheet.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/FontBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ActiveDOMObject.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/ActiveDOMObject.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/ContainerNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DocumentLifecycle.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DocumentLifecycle.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DocumentMarkerController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Element.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/Node.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/dom/TreeScope.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/TreeScope.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/TreeShared.h View 5 chunks +8 lines, -8 lines 0 comments Download
M Source/core/editing/EditorCommand.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/TextIterator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/MemoryCache.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/fetch/RawResource.h View 1 chunk +1 line, -1 line 1 comment Download
M Source/core/frame/EventHandlerRegistry.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/EventHandlerRegistry.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/frame/LocalDOMWindow.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/LocalDOMWindow.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/frame/SuspendableTimer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/SuspendableTimer.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLCanvasElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLFormElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLSelectElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/CodeGeneratorInspector.py View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorCounters.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/DragController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/FocusController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/Page.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/Page.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/ClipRectsCache.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderBlockFlow.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderGeometryMap.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderGeometryMap.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M Source/core/rendering/RenderInline.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderLayer.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderLayerClipper.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderLayerStackingNode.h View 5 chunks +5 lines, -5 lines 0 comments Download
M Source/core/rendering/RenderLayerStackingNode.cpp View 7 chunks +7 lines, -7 lines 0 comments Download
M Source/core/rendering/compositing/CompositedLayerMapping.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/compositing/CompositedLayerMapping.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/compositing/CompositingInputsUpdater.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/compositing/CompositingInputsUpdater.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/compositing/CompositingRequirementsUpdater.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/compositing/GraphicsLayerTreeBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/compositing/GraphicsLayerUpdater.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/compositing/GraphicsLayerUpdater.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/compositing/RenderLayerCompositor.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/compositing/RenderLayerCompositor.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M Source/core/svg/SVGDocumentExtensions.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGDocumentExtensions.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGUseElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/testing/InternalSettings.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/XPathStep.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/crypto/NormalizeAlgorithm.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/encryptedmedia/MediaKeys.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/Database.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/DatabaseManager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/webdatabase/DatabaseManager.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/platform/RefCountedSupplement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/ScriptForbiddenScope.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/ScriptForbiddenScope.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/Supplementable.h View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/platform/audio/android/FFTFrameOpenMAXDLAndroid.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/audio/ffmpeg/FFTFrameFFMPEG.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/FontCache.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/BitmapImage.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/BitmapImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/Canvas2DLayerBridge.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/GraphicsContext.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/graphics/GraphicsContext.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M Source/platform/graphics/GraphicsLayer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/GraphicsLayer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/Image.h View 2 chunks +2 lines, -1 line 1 comment Download
M Source/platform/graphics/Path.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/Path.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/image-decoders/ImageFrame.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/platform/image-decoders/ImageFrame.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/mac/BlockExceptions.mm View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebAXObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/wtf/Assertions.h View 4 chunks +16 lines, -12 lines 1 comment Download
M Source/wtf/BloomFilter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/wtf/DateMath.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/wtf/HashTable.h View 10 chunks +10 lines, -10 lines 0 comments Download
M Source/wtf/LinkedHashSet.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/wtf/RefCounted.h View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/wtf/SizeLimits.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/wtf/StringHasher.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/wtf/ThreadRestrictionVerifier.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/wtf/dtoa/cached-powers.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
Ken Russell (switch to Gerrit)
Adam: per our offline discussion, here's the mechanical search-and-replace for your rubber stamp. https://codereview.chromium.org/394353002/diff/1/Source/core/fetch/RawResource.h File ...
6 years, 5 months ago (2014-07-16 22:04:56 UTC) #1
abarth-chromium
LGTM
6 years, 5 months ago (2014-07-16 22:09:29 UTC) #2
Ken Russell (switch to Gerrit)
The CQ bit was checked by kbr@chromium.org
6 years, 5 months ago (2014-07-16 22:15:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kbr@chromium.org/394353002/1
6 years, 5 months ago (2014-07-16 22:15:53 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-16 23:07:01 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-16 23:41:09 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/17362)
6 years, 5 months ago (2014-07-16 23:41:11 UTC) #7
Ken Russell (switch to Gerrit)
That failure is a problem on the bot and has been filed as http://crbug.com/394563 . ...
6 years, 5 months ago (2014-07-16 23:50:36 UTC) #8
Ken Russell (switch to Gerrit)
The CQ bit was checked by kbr@chromium.org
6 years, 5 months ago (2014-07-16 23:50:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kbr@chromium.org/394353002/1
6 years, 5 months ago (2014-07-16 23:51:43 UTC) #10
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 00:55:38 UTC) #11
Message was sent while issue was closed.
Change committed as 178303

Powered by Google App Engine
This is Rietveld 408576698