Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Unified Diff: sync/internal_api/write_transaction.cc

Issue 394293003: Do not update AttachmentIds after uploading attachments to sync server. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/internal_api/public/write_transaction.h ('k') | sync/syncable/directory_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/internal_api/write_transaction.cc
diff --git a/sync/internal_api/write_transaction.cc b/sync/internal_api/write_transaction.cc
index 70e902954dc1f54ad87646c36bb0fddf513e4275..5415564aca18700990111b0d41693d9ab5315bb8 100644
--- a/sync/internal_api/write_transaction.cc
+++ b/sync/internal_api/write_transaction.cc
@@ -81,7 +81,7 @@ void WriteTransaction::SetDataTypeContext(
// See crbug.com/360280
}
-void WriteTransaction::UpdateEntriesWithAttachmentId(
+void WriteTransaction::UpdateEntriesMarkAttachmentAsOnServer(
const AttachmentId& attachment_id) {
syncable::Directory::Metahandles handles;
GetDirectory()->GetMetahandlesByAttachmentId(
@@ -90,7 +90,7 @@ void WriteTransaction::UpdateEntriesWithAttachmentId(
iter != handles.end();
++iter) {
syncable::MutableEntry entry(transaction_, syncable::GET_BY_HANDLE, *iter);
- entry.UpdateAttachmentIdWithServerInfo(attachment_id.GetProto());
+ entry.MarkAttachmentAsOnServer(attachment_id.GetProto());
}
}
« no previous file with comments | « sync/internal_api/public/write_transaction.h ('k') | sync/syncable/directory_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698