sync/syncable/directory_unittest.cc - Issue 394293003: Do not update AttachmentIds after uploading attachments to sync server.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/syncable/directory_unittest.cc

Issue 394293003: Do not update AttachmentIds after uploading attachments to sync server. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sync/syncable/directory_unittest.cc

diff --git a/sync/syncable/directory_unittest.cc b/sync/syncable/directory_unittest.cc

index adc4004682995e944223e942721868165979bcfd..efc97e62defd7703e860885d6b8fd80fd59b3932 100644

--- a/sync/syncable/directory_unittest.cc

+++ b/sync/syncable/directory_unittest.cc

@@ -1649,8 +1649,7 @@ TEST_F(SyncableDirectoryTest, MutableEntry_UpdateAttachmentId) {

ASSERT_FALSE(entry_metadata.record(1).is_on_server());

ASSERT_FALSE(entry.GetIsUnsynced());

- // TODO(pavely): When we add server info to proto, add test for it here.

- entry.UpdateAttachmentIdWithServerInfo(attachment_id_proto);

+ entry.MarkAttachmentAsOnServer(attachment_id_proto);

ASSERT_TRUE(entry_metadata.record(0).is_on_server());

ASSERT_FALSE(entry_metadata.record(1).is_on_server());

« no previous file with comments | « sync/internal_api/write_transaction.cc ('k') | sync/syncable/mutable_entry.h » ('j') | no next file with comments »