Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Unified Diff: sync/internal_api/public/write_transaction.h

Issue 394293003: Do not update AttachmentIds after uploading attachments to sync server. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/internal_api/attachments/fake_attachment_uploader.cc ('k') | sync/internal_api/write_transaction.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/internal_api/public/write_transaction.h
diff --git a/sync/internal_api/public/write_transaction.h b/sync/internal_api/public/write_transaction.h
index 06d13545986c1dbdd799a01b94ccd7e5e42689fa..2dbcdaa5c725f6fdc253fbfd2ee8e8107fe8096e 100644
--- a/sync/internal_api/public/write_transaction.h
+++ b/sync/internal_api/public/write_transaction.h
@@ -52,9 +52,9 @@ class SYNC_EXPORT WriteTransaction : public BaseTransaction {
syncer::SyncChangeProcessor::ContextRefreshStatus refresh_status,
const std::string& context);
- // Attachment id was just updated. Propagate this change to all entries that
- // refer this attachment id and set is_on_server for corresponding records.
- void UpdateEntriesWithAttachmentId(const AttachmentId& attachment_id);
+ // Update all entries that refer to |attachment_id| indicating that
+ // |attachment_id| has been uploaded to the sync server.
+ void UpdateEntriesMarkAttachmentAsOnServer(const AttachmentId& attachment_id);
protected:
WriteTransaction() {}
« no previous file with comments | « sync/internal_api/attachments/fake_attachment_uploader.cc ('k') | sync/internal_api/write_transaction.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698