Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: sync/internal_api/attachments/fake_attachment_uploader.cc

Issue 394293003: Do not update AttachmentIds after uploading attachments to sync server. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/internal_api/attachments/fake_attachment_uploader.cc
diff --git a/sync/internal_api/attachments/fake_attachment_uploader.cc b/sync/internal_api/attachments/fake_attachment_uploader.cc
index 743b534e839a3695137f308fb7433e8d23108a6f..1ffbe5b0539f690c75f11ac15a548edfac94323e 100644
--- a/sync/internal_api/attachments/fake_attachment_uploader.cc
+++ b/sync/internal_api/attachments/fake_attachment_uploader.cc
@@ -25,11 +25,9 @@ void FakeAttachmentUploader::UploadAttachment(const Attachment& attachment,
DCHECK(!attachment.GetId().GetProto().unique_id().empty());
UploadResult result = UPLOAD_SUCCESS;
- AttachmentId updated_id = attachment.GetId();
- // TODO(maniscalco): Update the attachment id with server address information
- // before passing it to the callback.
- base::MessageLoop::current()->PostTask(
- FROM_HERE, base::Bind(callback, result, updated_id));
+ AttachmentId id = attachment.GetId();
+ base::MessageLoop::current()->PostTask(FROM_HERE,
+ base::Bind(callback, result, id));
}
} // namespace syncer
« no previous file with comments | « sync/internal_api/attachments/attachment_uploader_impl_unittest.cc ('k') | sync/internal_api/public/write_transaction.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698