QUIC - minor cleanup changes.

QUIC - minor cleanup changes.
  + Fixed indentation.
  + Added early returns.
  + Fixed comments.
  + Removed not needed virtual.

Fixed nit comments from wtc for the following CLs.

  https://codereview.chromium.org/368803003/
  https://codereview.chromium.org/366863002/
  https://codereview.chromium.org/393953011/

R=wtc@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284109

[wtc, 2014-07-16 20:42:47]

Patch set 1 LGTM.

https://codereview.chromium.org/394053003/diff/1/net/quic/quic_connection.h
File net/quic/quic_connection.h (right):

https://codereview.chromium.org/394053003/diff/1/net/quic/quic_connection.h#n...
net/quic/quic_connection.h:309: bool ProcessValidatedPacket();

IMPORTANT: please undo this change. I found that an internal subclass of
QuicConnection does override this method, so it needs to be virtual. Sorry about
my mistake.

However, it probably can be a protected method. I'll try that change.

https://codereview.chromium.org/394053003/diff/1/net/quic/quic_crypto_client_...
File net/quic/quic_crypto_client_stream.cc (right):

https://codereview.chromium.org/394053003/diff/1/net/quic/quic_crypto_client_...
net/quic/quic_crypto_client_stream.cc:139: const CryptoHandshakeMessage& in) {

Nit: please name the input "server_config_update".

https://codereview.chromium.org/394053003/diff/1/net/quic/quic_crypto_client_...
File net/quic/quic_crypto_client_stream.h (right):

https://codereview.chromium.org/394053003/diff/1/net/quic/quic_crypto_client_...
net/quic/quic_crypto_client_stream.h:109: void
HandleServerConfigUpdateMessage(const CryptoHandshakeMessage& in);

Nit: please name the input "server_config_update".

[ramant (doing other things), 2014-07-16 22:31:40]

https://codereview.chromium.org/394053003/diff/1/net/quic/quic_connection.h
File net/quic/quic_connection.h (right):

https://codereview.chromium.org/394053003/diff/1/net/quic/quic_connection.h#n...
net/quic/quic_connection.h:309: bool ProcessValidatedPacket();
On 2014/07/16 20:42:46, wtc wrote:
> 
> IMPORTANT: please undo this change. I found that an internal subclass of
> QuicConnection does override this method, so it needs to be virtual. Sorry
about
> my mistake.
> 
> However, it probably can be a protected method. I'll try that change.

Undid the change. Saw you have submitted a CL to make it protected, thus didn't
make that change.

https://codereview.chromium.org/394053003/diff/1/net/quic/quic_crypto_client_...
File net/quic/quic_crypto_client_stream.cc (right):

https://codereview.chromium.org/394053003/diff/1/net/quic/quic_crypto_client_...
net/quic/quic_crypto_client_stream.cc:139: const CryptoHandshakeMessage& in) {
On 2014/07/16 20:42:46, wtc wrote:
> 
> Nit: please name the input "server_config_update".

Done.

https://codereview.chromium.org/394053003/diff/1/net/quic/quic_crypto_client_...
File net/quic/quic_crypto_client_stream.h (right):

https://codereview.chromium.org/394053003/diff/1/net/quic/quic_crypto_client_...
net/quic/quic_crypto_client_stream.h:109: void
HandleServerConfigUpdateMessage(const CryptoHandshakeMessage& in);
On 2014/07/16 20:42:47, wtc wrote:
> 
> Nit: please name the input "server_config_update".

Done.

[ramant (doing other things), 2014-07-18 13:11:40]

The CQ bit was checked by rtenneti@chromium.org

[commit-bot: I haz the power, 2014-07-18 13:12:36]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rtenneti@chromium.org/394053003/40001

[commit-bot: I haz the power, 2014-07-18 15:12:43]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[commit-bot: I haz the power, 2014-07-18 16:06:27]

Change committed as 284109