Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(668)

Unified Diff: chrome/browser/views/browser_bubble_win.cc

Issue 394004: Mostly fixes black flashing that happens during popup resize. (Closed)
Patch Set: a better fix Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/views/browser_bubble_win.cc
diff --git a/chrome/browser/views/browser_bubble_win.cc b/chrome/browser/views/browser_bubble_win.cc
index d25fea387d586e65526ccb0fbf2042fdc54d2ab6..3b0b9b8d69fcb92a6ea40a6091816510dddeadf6 100644
--- a/chrome/browser/views/browser_bubble_win.cc
+++ b/chrome/browser/views/browser_bubble_win.cc
@@ -14,6 +14,8 @@ class BubbleWidget : public views::WidgetWin {
public:
explicit BubbleWidget(BrowserBubble* bubble)
: bubble_(bubble), closed_(false) {
+ set_window_style(WS_POPUP | WS_CLIPCHILDREN);
amit 2009/11/16 18:06:27 This will work but it sets the window style per in
+ set_window_ex_style(WS_EX_TOOLWINDOW);
}
void Show(bool activate) {
@@ -70,7 +72,6 @@ void BrowserBubble::InitPopup() {
// popup_ is a Widget, but we need to do some WidgetWin stuff first, then
// we'll assign it into popup_.
views::WidgetWin* pop = new BubbleWidget(this);
- pop->set_window_style(WS_POPUP);
pop->Init(frame_native_view_, bounds_);
pop->SetContentsView(view_);
@@ -81,7 +82,7 @@ void BrowserBubble::InitPopup() {
void BrowserBubble::MovePopup(int x, int y, int w, int h) {
views::WidgetWin* pop = static_cast<views::WidgetWin*>(popup_);
- pop->MoveWindow(x, y, w, h);
+ pop->SetBounds(gfx::Rect(x, y, w, h));
}
void BrowserBubble::Show(bool activate) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698