Mostly fixes black flashing that happens during popup resize.

chrome/browser/views/browser_bubble_win.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/views/browser_bubble.h"
 
 #include "app/l10n_util_win.h"
 #include "chrome/browser/views/frame/browser_view.h"
 #include "views/widget/root_view.h"
 #include "views/widget/widget_win.h"
 #include "views/window/window.h"
 
 class BubbleWidget : public views::WidgetWin {
  public:
   explicit BubbleWidget(BrowserBubble* bubble)
       : bubble_(bubble), closed_(false) {
+    set_window_style(WS_POPUP | WS_CLIPCHILDREN);

[amit, 2009/11/16 18:06:27]

This will work but it sets the window style per instance. Ideally for all
instances of BubbleWidget, the style should be specified by the class style.
Even better would be if all the WidgetWin window class could have this style.
This could be done by adding WS_CLIPCHILDREN | WS_CLIPSIBLINGS to the
kWindowDefaultStyle in window_impl.cc  Adding it here would make sure that the
flicker issue would not have to be debugged and fixed elsewhere in future :)

+    set_window_ex_style(WS_EX_TOOLWINDOW);
   }
 
   void Show(bool activate) {
     if (activate)
       ShowWindow(SW_SHOW);
     else
       views::WidgetWin::Show();
   }
 
   void Close() {
@@ skipping 36 matching lines @@
 
  private:
   bool closed_;
   BrowserBubble* bubble_;
 };
 
 void BrowserBubble::InitPopup() {
   // popup_ is a Widget, but we need to do some WidgetWin stuff first, then
   // we'll assign it into popup_.
   views::WidgetWin* pop = new BubbleWidget(this);
-  pop->set_window_style(WS_POPUP);
   pop->Init(frame_native_view_, bounds_);
   pop->SetContentsView(view_);
 
   popup_ = pop;
   Reposition();
   AttachToBrowser();
 }
 
 void BrowserBubble::MovePopup(int x, int y, int w, int h) {
   views::WidgetWin* pop = static_cast<views::WidgetWin*>(popup_);
-  pop->MoveWindow(x, y, w, h);
+  pop->SetBounds(gfx::Rect(x, y, w, h));
 }
 
 void BrowserBubble::Show(bool activate) {
   if (visible_)
     return;
   BubbleWidget* pop = static_cast<BubbleWidget*>(popup_);
   pop->Show(activate);
   visible_ = true;
 }
 
 void BrowserBubble::Hide() {
   if (!visible_)
     return;
   views::WidgetWin* pop = static_cast<views::WidgetWin*>(popup_);
   pop->Hide();
   visible_ = false;
 }