Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Issue 394004: Mostly fixes black flashing that happens during popup resize. (Closed)

Created:
11 years, 1 month ago by Erik does not do reviews
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Mostly fixes black flashing that happens during popup resize. BUG=25459 TEST=none TBR=amit Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32008

Patch Set 1 #

Patch Set 2 : nada #

Patch Set 3 : a better fix #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/browser/views/browser_bubble_win.cc View 1 2 3 chunks +3 lines, -2 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
Erik does not do reviews
Thanks for your feedback offline. This is a better fix for the problem.
11 years, 1 month ago (2009-11-14 20:49:32 UTC) #1
Erik does not do reviews
I'm going to submit this TBR as it seems like a pretty safe fix and ...
11 years, 1 month ago (2009-11-14 22:04:44 UTC) #2
Aaron Boodman
Ok
11 years, 1 month ago (2009-11-14 22:27:10 UTC) #3
amit
lgtm http://codereview.chromium.org/394004/diff/2001/3001 File chrome/browser/views/browser_bubble_win.cc (right): http://codereview.chromium.org/394004/diff/2001/3001#newcode17 Line 17: set_window_style(WS_POPUP | WS_CLIPCHILDREN); This will work but ...
11 years, 1 month ago (2009-11-16 18:06:26 UTC) #4
Peter Kasting
11 years, 1 month ago (2009-11-16 20:16:03 UTC) #5
On 2009/11/16 18:06:26, amit wrote:
> http://codereview.chromium.org/394004/diff/2001/3001#newcode17
> Line 17: set_window_style(WS_POPUP | WS_CLIPCHILDREN);
> This will work but it sets the window style per instance. Ideally for all
> instances of BubbleWidget, the style should be specified by the class style.
> Even better would be if all the WidgetWin window class could have this style.
> This could be done by adding WS_CLIPCHILDREN | WS_CLIPSIBLINGS to the
> kWindowDefaultStyle in window_impl.cc  Adding it here would make sure that the
> flicker issue would not have to be debugged and fixed elsewhere in future :)

^^^ This, for both the class style comment and the addition of WS_CLIPSIBLINGS

Powered by Google App Engine
This is Rietveld 408576698