Mostly fixes black flashing that happens during popup resize.

Mostly fixes black flashing that happens during popup resize.

BUG=25459
TEST=none
TBR=amit

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32008

[Erik does not do reviews, 2009-11-14 20:49:32]

Thanks for your feedback offline.  This is a better fix for the problem.

[Erik does not do reviews, 2009-11-14 22:04:44]

I'm going to submit this TBR as it seems like a pretty safe fix and I'd like to
land it this weekend.

[Aaron Boodman, 2009-11-14 22:27:10]

Ok

[amit, 2009-11-16 18:06:26]

lgtm

http://codereview.chromium.org/394004/diff/2001/3001
File chrome/browser/views/browser_bubble_win.cc (right):

http://codereview.chromium.org/394004/diff/2001/3001#newcode17
Line 17: set_window_style(WS_POPUP | WS_CLIPCHILDREN);
This will work but it sets the window style per instance. Ideally for all
instances of BubbleWidget, the style should be specified by the class style.
Even better would be if all the WidgetWin window class could have this style.
This could be done by adding WS_CLIPCHILDREN | WS_CLIPSIBLINGS to the
kWindowDefaultStyle in window_impl.cc  Adding it here would make sure that the
flicker issue would not have to be debugged and fixed elsewhere in future :)

[Peter Kasting, 2009-11-16 20:16:03]

On 2009/11/16 18:06:26, amit wrote:
> http://codereview.chromium.org/394004/diff/2001/3001#newcode17
> Line 17: set_window_style(WS_POPUP | WS_CLIPCHILDREN);
> This will work but it sets the window style per instance. Ideally for all
> instances of BubbleWidget, the style should be specified by the class style.
> Even better would be if all the WidgetWin window class could have this style.
> This could be done by adding WS_CLIPCHILDREN | WS_CLIPSIBLINGS to the
> kWindowDefaultStyle in window_impl.cc  Adding it here would make sure that the
> flicker issue would not have to be debugged and fixed elsewhere in future :)

^^^ This, for both the class style comment and the addition of WS_CLIPSIBLINGS