Chromium Code Reviews Chromium Code Reviews
Issue
393953009:
Moving the work currently done in the QuicSession constructor to (Closed)
DescriptionMoving the work currently done in the QuicSession constructor to
Initialize().
This is worthwhile because currently it's possible for virtual functions
to be called from under the stack of the QuicSession constructor, which
is confusing and annoying to debug. Example: if a bad config (without
SetDefaults called) is passed to the quic server session, it calls
SetFromConfig which calls SetIdleNetworkTimeout which calls
CheckForTimeout which can technically call SendConnectionClose which
calls CloseConnection which calls visitor->OnConnectionClosed() on the
session, which still doesn't have a good vtable.
As it turns out, this puts the internal server in an inconsistent state
which causes all sorts of other annoying to debug things. This can be
solved by never giving an invalid config (heh) or, say, not doing a ton
of complicated work in a constructor in the first place.
This hopefully will also make some unit testing earlier as you don't
have to do quite as much work in test classes.
Moving work from the QuicSession constructor to InitializeSession()
Merge internal change: 70661792
R=rch@chromium.org
Patch Set 1 #
Total comments: 2
Messages
Total messages: 3 (0 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
