Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 393953008: Add ui/display, message_center, webview to GN build. (Closed)

Created:
6 years, 5 months ago by brettw
Modified:
6 years, 5 months ago
Reviewers:
tfarina, sky
CC:
chromium-reviews, rjkroege, ozone-reviews_chromium.org, tfarina, jam, darin-cc_chromium.org, kalyank
Project:
chromium
Visibility:
Public.

Description

Add display, message_center, shell_dialogs, webview to GN build. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283516

Patch Set 1 #

Total comments: 4

Patch Set 2 : merge #

Patch Set 3 : #

Patch Set 4 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+566 lines, -17 lines) Patch
M BUILD.gn View 1 2 3 3 chunks +4 lines, -0 lines 0 comments Download
M build/config/features.gni View 1 chunk +2 lines, -2 lines 0 comments Download
M build/config/linux/BUILD.gn View 1 2 3 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M content/common/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/ui_base.gyp View 5 chunks +6 lines, -0 lines 0 comments Download
A ui/display/BUILD.gn View 1 chunk +106 lines, -0 lines 0 comments Download
M ui/display/display.gyp View 9 chunks +9 lines, -0 lines 0 comments Download
A ui/display/types/BUILD.gn View 1 chunk +27 lines, -0 lines 0 comments Download
A ui/display/util/BUILD.gn View 1 chunk +35 lines, -0 lines 0 comments Download
A ui/message_center/BUILD.gn View 1 chunk +227 lines, -0 lines 0 comments Download
M ui/message_center/message_center.gyp View 8 chunks +6 lines, -3 lines 0 comments Download
M ui/ozone/BUILD.gn View 1 chunk +1 line, -3 lines 0 comments Download
A ui/shell_dialogs/BUILD.gn View 1 chunk +86 lines, -0 lines 0 comments Download
M ui/shell_dialogs/shell_dialogs.gyp View 5 chunks +6 lines, -2 lines 0 comments Download
M ui/views/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
A ui/views/controls/webview/BUILD.gn View 1 chunk +38 lines, -0 lines 0 comments Download
M ui/views/controls/webview/webview.gyp View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
brettw
6 years, 5 months ago (2014-07-16 00:15:21 UTC) #1
tfarina
https://codereview.chromium.org/393953008/diff/1/ui/shell_dialogs/BUILD.gn File ui/shell_dialogs/BUILD.gn (right): https://codereview.chromium.org/393953008/diff/1/ui/shell_dialogs/BUILD.gn#newcode51 ui/shell_dialogs/BUILD.gn:51: deps += [ "//ui/aura" ] Haven't you got any ...
6 years, 5 months ago (2014-07-16 00:36:26 UTC) #2
brettw
https://codereview.chromium.org/393953008/diff/1/ui/shell_dialogs/BUILD.gn File ui/shell_dialogs/BUILD.gn (right): https://codereview.chromium.org/393953008/diff/1/ui/shell_dialogs/BUILD.gn#newcode51 ui/shell_dialogs/BUILD.gn:51: deps += [ "//ui/aura" ] On 2014/07/16 00:36:26, tfarina ...
6 years, 5 months ago (2014-07-16 01:00:00 UTC) #3
sky
LGTM
6 years, 5 months ago (2014-07-16 14:55:17 UTC) #4
brettw
6 years, 5 months ago (2014-07-16 21:33:57 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 manually as r283516 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698