[Android] Make BookmarksBridge#getSubFolders function more flexible.

[Android] Make BookmarksBridge#getSubFolders function more flexible.

Renamed getSubFolders to getChildIDs and added two boolean arguments
that specifies if the function should return folders or bookmarks or
both.

BUG=386785
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283351

[newt (away), 2014-07-15 18:27:50]

This will be easier to land if you add a new method getChildIDs() and remove
getSubFolders() later in a separate CL.

https://codereview.chromium.org/393943002/diff/1/chrome/android/java/src/org/...
File chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java
(right):

https://codereview.chromium.org/393943002/diff/1/chrome/android/java/src/org/...
chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java:192: *
@return Sub-folders of the given folder.
update comment?

[Kibeom Kim (inactive), 2014-07-15 18:33:41]

Actually, there is no place that calls getSubFolders() yet, other than the CL
getting reviewed. https://chrome-internal-review.googlesource.com/#/c/168488/

https://codereview.chromium.org/393943002/diff/1/chrome/android/java/src/org/...
File chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java
(right):

https://codereview.chromium.org/393943002/diff/1/chrome/android/java/src/org/...
chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java:192: *
@return Sub-folders of the given folder.
On 2014/07/15 18:27:50, newt wrote:
> update comment?

Done.

[newt (away), 2014-07-15 18:38:12]

lgtm

Oh, sweet. That's even easier.

[David Trainor- moved to gerrit, 2014-07-15 18:46:20]

lgtm

https://chromiumcodereview.appspot.com/393943002/diff/20001/chrome/android/ja...
File chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java
(right):

https://chromiumcodereview.appspot.com/393943002/diff/20001/chrome/android/ja...
chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java:195:
public List<BookmarkId> getChildIDs(BookmarkId id, boolean getFolders, boolean
getBookmarks) {
Flesh out this javadoc?

[Kibeom Kim (inactive), 2014-07-15 18:55:11]

https://codereview.chromium.org/393943002/diff/20001/chrome/android/java/src/...
File chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java
(right):

https://codereview.chromium.org/393943002/diff/20001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java:195:
public List<BookmarkId> getChildIDs(BookmarkId id, boolean getFolders, boolean
getBookmarks) {
On 2014/07/15 18:46:20, David Trainor wrote:
> Flesh out this javadoc?

Done.

[Kibeom Kim (inactive), 2014-07-15 18:55:13]

The CQ bit was checked by kkimlabs@chromium.org

[commit-bot: I haz the power, 2014-07-15 18:57:31]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kkimlabs@chromium.org/393943002/40001

[commit-bot: I haz the power, 2014-07-16 05:15:08]

Change committed as 283351