Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3968)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java

Issue 393943002: [Android] Make BookmarksBridge#getSubFolders function more flexible. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comment flesh out Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java
index bdb3004d9ac14213f7956b88b1b43315ede32cca..94bd886724f4363f2a9b8beddfb6592cb4d99293 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java
@@ -189,12 +189,21 @@ public class BookmarksBridge {
}
/**
- * @return Sub-folders of the given folder.
+ * Reads sub-folder IDs, sub-bookmark IDs, or both of the given folder.
+ *
+ * @param getFolders Whether sub-folders should be returned.
+ * @param getBookmarks Whether sub-bookmarks should be returned.
+ * @return Child IDs of the given folder, with the specified type.
*/
- public List<BookmarkId> getSubFolders(BookmarkId id) {
+ public List<BookmarkId> getChildIDs(BookmarkId id, boolean getFolders, boolean getBookmarks) {
assert mIsNativeBookmarkModelLoaded;
List<BookmarkId> result = new ArrayList<BookmarkId>();
- nativeGetChildIDs(mNativeBookmarksBridge, id.mId, id.mType, true, false, result);
+ nativeGetChildIDs(mNativeBookmarksBridge,
+ id.mId,
+ id.mType,
+ getFolders,
+ getBookmarks,
+ result);
return result;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698