Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(982)

Issue 393933004: Send the real key code in deleteSurroundingText (Closed)

Created:
6 years, 5 months ago by guohui
Modified:
6 years, 5 months ago
CC:
bcwhite, chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Send the real key code in deleteSurroundingText On android, when user presses DEL or FORWARD_DEL using IME, Chrome generates key events with 0 keycode. This breaks lots of websites who count on having the real keycode in the key event listeners, especially for the control keys such as DEL and FORWARD_DEL. This CL fixes the issue for the most common case when a single char is deleted. Instead of triggering deleteSurroudingText path with synthetic key events of key code 0, Chrome sends native key events with real key code. BUG=118639 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283989

Patch Set 1 : #

Total comments: 1

Patch Set 2 : added tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -11 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java View 1 chunk +24 lines, -1 line 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java View 1 chunk +0 lines, -8 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/input/AdapterInputConnectionTest.java View 1 4 chunks +54 lines, -2 lines 0 comments Download
M content/renderer/render_widget.cc View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
guohui
Hey, could you please review the CL? tkent@ for owner review of content/renderer/render_widget.cc aurimas for ...
6 years, 5 months ago (2014-07-15 22:33:55 UTC) #1
aurimas (slooooooooow)
lgtm https://codereview.chromium.org/393933004/diff/20001/content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java File content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java (right): https://codereview.chromium.org/393933004/diff/20001/content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java#newcode365 content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java:365: if (event.getKeyCode() == KeyEvent.KEYCODE_DEL) { Can we also ...
6 years, 5 months ago (2014-07-15 23:00:28 UTC) #2
tkent
I'm not an owner of these files. +jochen.
6 years, 5 months ago (2014-07-15 23:17:27 UTC) #3
guohui
On 2014/07/15 23:17:27, tkent wrote: > I'm not an owner of these files. +jochen. Oops ...
6 years, 5 months ago (2014-07-16 18:01:38 UTC) #4
guohui
On 2014/07/16 18:01:38, guohui wrote: > On 2014/07/15 23:17:27, tkent wrote: > > I'm not ...
6 years, 5 months ago (2014-07-17 16:19:37 UTC) #5
guohui
Tests added in patch 2.
6 years, 5 months ago (2014-07-17 18:19:05 UTC) #6
jochen (gone - plz use gerrit)
lgtm
6 years, 5 months ago (2014-07-17 18:35:39 UTC) #7
guohui
The CQ bit was checked by guohui@chromium.org
6 years, 5 months ago (2014-07-17 18:36:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/guohui@chromium.org/393933004/60001
6 years, 5 months ago (2014-07-17 18:38:02 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-18 01:29:27 UTC) #10
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 03:09:57 UTC) #11
Message was sent while issue was closed.
Change committed as 283989

Powered by Google App Engine
This is Rietveld 408576698