content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java - Issue 393933004: Send the real key code in deleteSurroundingText

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java

Issue 393933004: Send the real key code in deleteSurroundingText (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: added tests Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java ('k') | content/public/android/javatests/src/org/chromium/content/browser/input/AdapterInputConnectionTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java b/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java

index 73735e0cdd4183676469dc4f4eb327f4af1d42d0..f5150578fa24e2d05785fc59fd92a097711df202 100644

--- a/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java

+++ b/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java

@@ -408,15 +408,7 @@ public class ImeAdapter {

boolean deleteSurroundingText(int beforeLength, int afterLength) {

mViewEmbedder.onImeEvent(false);

if (mNativeImeAdapterAndroid == 0) return false;

- // Can't send the deletion key code yet because it will delete an extra char at the end.

- // Also the deleteSurroundingText message is not always ordered properly with key event

- // messages yet.

- // TODO(guohui): fix the ordering and send the deletion key code for single-char deletion.

- sendSyntheticKeyEvent(

- sEventTypeRawKeyDown, SystemClock.uptimeMillis(), KeyEvent.KEYCODE_UNKNOWN, 0);

nativeDeleteSurroundingText(mNativeImeAdapterAndroid, beforeLength, afterLength);

- sendSyntheticKeyEvent(

- sEventTypeKeyUp, SystemClock.uptimeMillis(), KeyEvent.KEYCODE_UNKNOWN, 0);

return true;

}