Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 393653002: Removed gesture tap highlight flags. (Closed)

Created:
6 years, 5 months ago by mustaq
Modified:
6 years, 5 months ago
CC:
jochen (gone - plz use gerrit), chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, davemoore+watch_chromium.org, jam, jochen+watch_chromium.org, kenrb, nasko+codewatch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Removed gesture tap highlight flags. This CL follows https://codereview.chromium.org/392783003, and will be followed by another CL to remove redundant fields & methods in blink. BUG=350531 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283667

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -28 lines) Patch
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/android/content_startup_flags.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/public/common/common_param_traits_macros.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.h View 2 chunks +0 lines, -2 lines 0 comments Download
M content/public/common/content_switches.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M content/public/common/web_preferences.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/web_preferences.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/shell/app/shell_main_delegate.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
mustaq
Here are all the changes in the chromium tree that compiled w/o changes in webkit.
6 years, 5 months ago (2014-07-14 21:32:41 UTC) #1
Rick Byers
This looks good, but you'll have to land the change in blink to ignore this ...
6 years, 5 months ago (2014-07-14 21:38:37 UTC) #2
Rick Byers
On 2014/07/14 21:38:37, Rick Byers wrote: > This looks good, but you'll have to land ...
6 years, 5 months ago (2014-07-15 15:59:57 UTC) #3
kenrb
ipc lgtm
6 years, 5 months ago (2014-07-15 16:27:21 UTC) #4
jochen (gone - plz use gerrit)
lgtm
6 years, 5 months ago (2014-07-16 14:43:45 UTC) #5
mustaq
The CQ bit was checked by mustaq@chromium.org
6 years, 5 months ago (2014-07-16 14:54:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mustaq@chromium.org/393653002/1
6 years, 5 months ago (2014-07-16 14:56:11 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 5 months ago (2014-07-17 05:46:20 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 06:45:55 UTC) #9
Message was sent while issue was closed.
Change committed as 283667

Powered by Google App Engine
This is Rietveld 408576698