Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 392783003: Unconditionally enable gesture tap highlight in blink. (Closed)

Created:
6 years, 5 months ago by mustaq
Modified:
6 years, 5 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Unconditionally enable gesture tap highlight in blink. This is the first in a series of CLs to remove gesture tap highlight flags. Subsequent changes for this bug will remove redundant fields & methods from chromium and blink. BUG=350531 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178188

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M Source/web/WebViewImpl.cpp View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
mustaq
See https://codereview.chromium.org/393653002 for upcoming changes in chromium.
6 years, 5 months ago (2014-07-14 22:35:06 UTC) #1
mustaq
6 years, 5 months ago (2014-07-14 22:35:44 UTC) #2
Rick Byers
LGTM Nits in description: - replace "WebKit" with "blink" - Edit the subject so its ...
6 years, 5 months ago (2014-07-14 23:30:29 UTC) #3
Rick Byers
On 2014/07/14 23:30:29, Rick Byers wrote: > LGTM > Nits in description: > - replace ...
6 years, 5 months ago (2014-07-14 23:32:06 UTC) #4
aelias_OOO_until_Jul13
lgtm
6 years, 5 months ago (2014-07-15 00:50:03 UTC) #5
mustaq
Done.
6 years, 5 months ago (2014-07-15 14:00:04 UTC) #6
Rick Byers
On 2014/07/15 14:00:04, mustaq wrote: > Done. Thanks, looks good. If the bots all return ...
6 years, 5 months ago (2014-07-15 14:13:18 UTC) #7
mustaq
The CQ bit was checked by mustaq@chromium.org
6 years, 5 months ago (2014-07-15 15:54:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mustaq@chromium.org/392783003/1
6 years, 5 months ago (2014-07-15 15:55:40 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-15 17:20:35 UTC) #10
Message was sent while issue was closed.
Change committed as 178188

Powered by Google App Engine
This is Rietveld 408576698