Fix compilation with OS X SDK 10.8.

Fix compilation with OS X SDK 10.8.

The system headers include visibility attributes, and thus should only be used if the frameworks are linked in.

BUG=393439
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283267

[sergeyv, 2014-07-14 21:29:27]

It works for me, thanks!

[Mark Mentovai, 2014-07-14 21:50:46]

Which SDK were you using when it broke, and how is it declaring things
incorrectly that caused this problem?

[pwnall-personal, 2014-07-14 22:06:51]

On 2014/07/14 21:50:46, Mark Mentovai wrote:
> Which SDK were you using when it broke, and how is it declaring things
> incorrectly that caused this problem?

This patch fixes the build for me as well.

I'm on OSX 10.9.4 with Xcode 5.1.1. I think these are the latest versions you
can get without a paid ADC membership. The build process selected the 10.8 SDK
by default. A default install of Xcode 5.1.1 only has the 10.8 and 10.9 SDKs in
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/.

I hope this helps.

[sandersd (OOO until July 31), 2014-07-14 22:19:53]

On 2014/07/14 21:50:46, Mark Mentovai wrote:
> Which SDK were you using when it broke, and how is it declaring things
> incorrectly that caused this problem?

The only thing special about these symbols is that they were declared both by
vt_stubs and by the system headers.

[sandersd (OOO until July 31), 2014-07-14 22:34:59]

On 2014/07/14 22:19:53, sandersd wrote:
> On 2014/07/14 21:50:46, Mark Mentovai wrote:
> > Which SDK were you using when it broke, and how is it declaring things
> > incorrectly that caused this problem?
> 
> The only thing special about these symbols is that they were declared both by
> vt_stubs and by the system headers.

Okay, it looks like the system headers add visibility attributes as part of the
SDK version macros, and so should only be included if we are also linking.

[scherkus (not reviewing), 2014-07-14 23:17:13]

On 2014/07/14 22:34:59, sandersd wrote:
> On 2014/07/14 22:19:53, sandersd wrote:
> > On 2014/07/14 21:50:46, Mark Mentovai wrote:
> > > Which SDK were you using when it broke, and how is it declaring things
> > > incorrectly that caused this problem?
> > 
> > The only thing special about these symbols is that they were declared both
by
> > vt_stubs and by the system headers.
> 
> Okay, it looks like the system headers add visibility attributes as part of
the
> SDK version macros, and so should only be included if we are also linking.

can you add that to the CL description?

other than that -- lgtm! thanks for the quick fix!

[sandersd (OOO until July 31), 2014-07-14 23:18:17]

The CQ bit was checked by sandersd@chromium.org

[commit-bot: I haz the power, 2014-07-14 23:19:03]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sandersd@chromium.org/393633002/1

[commit-bot: I haz the power, 2014-07-15 10:48:19]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-07-15 16:50:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-15 16:50:16]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[Mathieu, 2014-07-15 17:01:35]

The CQ bit was checked by mathp@chromium.org

[commit-bot: I haz the power, 2014-07-15 17:03:00]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sandersd@chromium.org/393633002/1

[commit-bot: I haz the power, 2014-07-15 18:49:21]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[commit-bot: I haz the power, 2014-07-15 19:26:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-15 19:26:35]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[sandersd (OOO until July 31), 2014-07-15 23:09:57]

The CQ bit was checked by sandersd@chromium.org

[commit-bot: I haz the power, 2014-07-15 23:11:28]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sandersd@chromium.org/393633002/1

[commit-bot: I haz the power, 2014-07-15 23:14:55]

Change committed as 283267