Reflected attributes should be removed when 'null', 'undefined' or 'false' is specified

Reflected attributes should be removed when 'null', 'undefined' or 'false' is specified

This is a follow-up CL to address arv's comment in https://codereview.chromium.org/386353002/#msg9.

Note that this CL will change existing behavior for reflected DOM attributes of HTMLMarqueeElement. Previously those reflected DOM attributes were not removed when 'null' or 'undefined' is specified. This was a bug. The new behavior implemented in this CL aligns with the spec and Firefox.

I don't have a concern about compatibility since this just affects reflected attributes of HTMLMarqueeElement.

BUG=341031
TEST=fast/html/marquee-element.html

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178076

[haraken, 2014-07-14 15:20:46]

arv@: PTAL

[arv (Not doing code reviews), 2014-07-14 15:24:29]

LGTM

You just fixed https://code.google.com/p/chromium/issues/detail?id=304959 for
HTMLMarqueeElement :-)

https://codereview.chromium.org/393543002/diff/20001/LayoutTests/fast/html/ma...
File LayoutTests/fast/html/marquee-element.html (right):

https://codereview.chromium.org/393543002/diff/20001/LayoutTests/fast/html/ma...
LayoutTests/fast/html/marquee-element.html:125: testParent.innerHTML = '<marquee
id="marquee" truespeed="true">test</marquee>';
testParent.innerHTML = '<marquee id="marquee" truespeed>test</marquee>';

The value does not matter

https://codereview.chromium.org/393543002/diff/20001/LayoutTests/fast/html/ma...
LayoutTests/fast/html/marquee-element.html:126: marquee =
document.getElementById('marquee');
just do testParent.firstChild?

[haraken, 2014-07-14 15:28:49]

Thanks for review!

https://codereview.chromium.org/393543002/diff/20001/LayoutTests/fast/html/ma...
File LayoutTests/fast/html/marquee-element.html (right):

https://codereview.chromium.org/393543002/diff/20001/LayoutTests/fast/html/ma...
LayoutTests/fast/html/marquee-element.html:125: testParent.innerHTML = '<marquee
id="marquee" truespeed="true">test</marquee>';
On 2014/07/14 15:24:29, arv wrote:
> testParent.innerHTML = '<marquee id="marquee" truespeed>test</marquee>';
> 
> The value does not matter

Done.

https://codereview.chromium.org/393543002/diff/20001/LayoutTests/fast/html/ma...
LayoutTests/fast/html/marquee-element.html:126: marquee =
document.getElementById('marquee');
On 2014/07/14 15:24:29, arv wrote:
> just do testParent.firstChild?

Other tests in this file are using getElementById, so I'll keep it as is.

[haraken, 2014-07-14 15:28:57]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2014-07-14 15:29:15]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/haraken@chromium.org/393543002/40001

[commit-bot: I haz the power, 2014-07-14 16:41:01]

Change committed as 178076