Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(736)

Issue 393353003: Improve the declared IDL type for postMessage()'s transferables (Closed)

Created:
6 years, 5 months ago by sof
Modified:
6 years, 5 months ago
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, serviceworker-reviews, arv+blink, tzik, sof, eae+blinkwatch, nhiroki, falken, blink-reviews-dom_chromium.org, dglazkov+blink, kinuko+serviceworker, Inactive, kinuko+worker_chromium.org, horo+watch_chromium.org, alecflett+watch_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Improve the declared IDL type for postMessage()'s transferables Make the postMessage() IDL type for the transferables argument be equal to what the specs and the custom binding code actually supports. That is, a sequence of Transferables. Accurately defining the Transferable typedef is dependent on better union type support (http://crbug.com/240176); provide an incomplete typedef until that is in place. R=haraken@chromium.org,jsbell@chromium.org BUG=393245 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178322

Patch Set 1 #

Total comments: 4

Patch Set 2 : Use sequence<Transferable> rather than Transferable[] #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -7 lines) Patch
M Source/core/dom/MessagePort.idl View 1 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/frame/Window.idl View 1 2 chunks +16 lines, -1 line 0 comments Download
M Source/core/workers/DedicatedWorkerGlobalScope.idl View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/Worker.idl View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/Client.idl View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/ServiceWorker.idl View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
sof
Please take a look.
6 years, 5 months ago (2014-07-16 15:31:23 UTC) #1
haraken
LGTM
6 years, 5 months ago (2014-07-16 16:02:12 UTC) #2
jsbell
lgtm, but can we use sequence<> to match the specs? https://codereview.chromium.org/393353003/diff/1/Source/core/dom/MessagePort.idl File Source/core/dom/MessagePort.idl (right): https://codereview.chromium.org/393353003/diff/1/Source/core/dom/MessagePort.idl#newcode32 ...
6 years, 5 months ago (2014-07-16 16:48:08 UTC) #3
sof
Thanks for the reviews. https://codereview.chromium.org/393353003/diff/1/Source/core/dom/MessagePort.idl File Source/core/dom/MessagePort.idl (right): https://codereview.chromium.org/393353003/diff/1/Source/core/dom/MessagePort.idl#newcode32 Source/core/dom/MessagePort.idl:32: On 2014/07/16 16:48:08, jsbell wrote: ...
6 years, 5 months ago (2014-07-16 18:19:15 UTC) #4
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 5 months ago (2014-07-16 18:28:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/393353003/20001
6 years, 5 months ago (2014-07-16 18:29:52 UTC) #6
sof
The CQ bit was unchecked by sigbjornf@opera.com
6 years, 5 months ago (2014-07-16 21:38:15 UTC) #7
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 5 months ago (2014-07-16 21:38:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/393353003/20001
6 years, 5 months ago (2014-07-16 21:39:43 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 05:07:07 UTC) #10
Message was sent while issue was closed.
Change committed as 178322

Powered by Google App Engine
This is Rietveld 408576698