Source/core/dom/MessagePort.idl - Issue 393353003: Improve the declared IDL type for postMessage()'s transferables

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/dom/MessagePort.idl

Issue 393353003: Improve the declared IDL type for postMessage()'s transferables (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2008 Apple Inc. All Rights Reserved.	2 * Copyright (C) 2008 Apple Inc. All Rights Reserved.

3 * Copyright (C) 2011 Google Inc. All Rights Reserved.	3 * Copyright (C) 2011 Google Inc. All Rights Reserved.

4 *	4 *

5 * Redistribution and use in source and binary forms, with or without	5 * Redistribution and use in source and binary forms, with or without

6 * modification, are permitted provided that the following conditions	6 * modification, are permitted provided that the following conditions

7 * are met:	7 * are met:

8 * 1. Redistributions of source code must retain the above copyright	8 * 1. Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * 2. Redistributions in binary form must reproduce the above copyright	10 * 2. Redistributions in binary form must reproduce the above copyright

(...skipping 11 matching lines...) Expand all Loading...
22 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT	22 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT

23 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE	23 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE

24 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.	24 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

25 *	25 *

26 */	26 */

27	27

28 [	28 [

29 ActiveDOMObject,	29 ActiveDOMObject,

30 WillBeGarbageCollected	30 WillBeGarbageCollected

31 ] interface MessagePort : EventTarget {	31 ] interface MessagePort : EventTarget {

32 [Custom, RaisesException] void postMessage(any message, optional MessagePort [] messagePorts);	32
	jsbell 2014/07/16 16:48:08 Nit: remove this whitespace? (Could just be a gli Nit: remove this whitespace? (Could just be a glitch in the review tool) sof 2014/07/16 18:19:15 It's real, but unintentional. Removed now. Show quoted text On 2014/07/16 16:48:08, jsbell wrote: > Nit: remove this whitespace? > > (Could just be a glitch in the review tool) It's real, but unintentional. Removed now.
	33 [Custom, RaisesException] void postMessage(any message, optional Transferabl e[] transfer);
	jsbell 2014/07/16 16:48:08 It appears to be sequence<Transferable> in specs r It appears to be sequence<Transferable> in specs rather than Transferable[]. sof 2014/07/16 18:19:15 Yes, that it is. Let's mirror that; supported by e Show quoted text On 2014/07/16 16:48:08, jsbell wrote: > It appears to be sequence<Transferable> in specs rather than Transferable[]. Yes, that it is. Let's mirror that; supported by extractTransferables() after all.
33	34

34 void start();	35 void start();

35 void close();	36 void close();

36	37

37 // event handler attributes	38 // event handler attributes

38 attribute EventHandler onmessage;	39 attribute EventHandler onmessage;

39 };	40 };

40

OLD	NEW

« no previous file with comments | « no previous file | Source/core/frame/Window.idl » ('j') | no next file with comments »