Issue 393193002: Add search_engines and precache components to GN build.

Issue 393193002: Add search_engines and precache components to GN build. (Closed)

Created:
6 years, 5 months ago by brettw

Modified:
6 years, 5 months ago

Reviewers:
viettrungluu

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Add search_engines and precache components to GN build. R=viettrungluu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283416

Patch Set 1 #

Total comments: 3

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+222 lines, -0 lines)			Patch
M	build/json_to_struct.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	components/BUILD.gn	View	3 chunks	+12 lines, -0 lines	0 comments	Download
M	components/precache.gypi	View	4 chunks	+4 lines, -0 lines	0 comments	Download
A	components/precache/content/BUILD.gn	View	1 chunk	+21 lines, -0 lines	0 comments	Download
A	components/precache/core/BUILD.gn	View	1 chunk	+44 lines, -0 lines	2 comments	Download
M	components/precache/precache_defines.gypi	View	1 chunk	+2 lines, -0 lines	1 comment	Download
M	components/search_engines.gypi	View	2 chunks	+2 lines, -0 lines	0 comments	Download
A	components/search_engines/BUILD.gn	View	1 chunk	+73 lines, -0 lines	0 comments	Download
M	components/search_engines/prepopulated_engines.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	tools/json_to_struct/json_to_struct.gni	View	1 chunk	+62 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

LGTM w/nit & question. https://codereview.chromium.org/393193002/diff/1/components/precache/core/BUILD.gn File components/precache/core/BUILD.gn (right): https://codereview.chromium.org/393193002/diff/1/components/precache/core/BUILD.gn#newcode7 components/precache/core/BUILD.gn:7: precache_config_settings_url = "http://www.gstatic.com/chrome/wifiprefetch/precache_config" Question: Should ...

6 years, 5 months ago (2014-07-16 02:53:36 UTC) #2

brettw

https://codereview.chromium.org/393193002/diff/1/components/precache/core/BUILD.gn File components/precache/core/BUILD.gn (right): https://codereview.chromium.org/393193002/diff/1/components/precache/core/BUILD.gn#newcode7 components/precache/core/BUILD.gn:7: precache_config_settings_url = "http://www.gstatic.com/chrome/wifiprefetch/precache_config" On 2014/07/16 02:53:36, viettrungluu wrote: > ...

6 years, 5 months ago (2014-07-16 16:36:09 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r283416.

Expand Messages | Collapse Messages