Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: components/BUILD.gn

Issue 393193002: Add search_engines and precache components to GN build. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/BUILD.gn
diff --git a/components/BUILD.gn b/components/BUILD.gn
index fa70043c3816d39873c9049a64bf6c379ce1c907..f86c640c7a25a8382591c273a6ced0416c5894b8 100644
--- a/components/BUILD.gn
+++ b/components/BUILD.gn
@@ -37,10 +37,13 @@ group("all_components") {
"//components/onc",
"//components/os_crypt",
"//components/policy",
+ "//components/precache/core",
+ "//components/precache/content",
"//components/pref_registry",
"//components/query_parser",
"//components/rappor",
"//components/resources:components_resources",
+ "//components/search_engines",
"//components/startup_metric_utils",
"//components/strings",
"//components/tracing",
@@ -91,8 +94,11 @@ group("all_components") {
"//components/history/core/test", # Should work, needs checking.
"//components/json_schema", # Should work, needs checking.
"//components/keyed_service/content", # Blocked on content.
+ "//components/precache/core", # Should work, needs checking.
+ "//components/precache/content", # Blocked on content.
"//components/policy", # Blocked on content (indirectly via autofill).
"//components/rappor", # Should work, needs checking.
+ "//components/search_engines", # Should work, needs checking.
"//components/translate/content/browser", # Blocked on content.
"//components/translate/content/common", # Blocked on content.
"//components/translate/content/renderer", # Blocked on content.
@@ -111,3 +117,9 @@ group("all_components") {
]
}
}
+
+# TODO(GYP) components_unittests
+#test("components_unittests") {
+## # Precache tests need these defines.
+# configs += [ "//components/precache/core:precache_config" ]
+#}

Powered by Google App Engine
This is Rietveld 408576698