Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 393123004: Cleanup usage of hard_dependency in grit targets. (Closed)

Created:
6 years, 5 months ago by tfarina
Modified:
6 years, 5 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org, Mark Mentovai, tony
Project:
chromium
Visibility:
Public.

Description

Cleanup usage of hard_dependency in grit targets. Since these targets are not static libraries, hard_dependency has no effect (confirmed by Mark Mentovai and Tony Chang). Files found with the following command line: $ for f in $(g ls-files | grep strings.gyp ); do grep hard_dependency $f; echo $f; done $ for f in $(g ls-files | grep resources.gyp ); do grep hard_dependency $f; echo $f; done BUG=None TEST=None R=jochen@chromium.org,yoz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284912

Patch Set 1 : #

Patch Set 2 : REBASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -11 lines) Patch
M components/components_resources.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M components/components_strings.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/extensions_strings.gyp View 1 chunk +4 lines, -9 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
tfarina
6 years, 5 months ago (2014-07-18 03:12:04 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 5 months ago (2014-07-18 09:11:04 UTC) #2
tfarina
+Benjamin for extensions/
6 years, 5 months ago (2014-07-22 18:15:30 UTC) #3
not at google - send to devlin
lgtm
6 years, 5 months ago (2014-07-22 18:22:56 UTC) #4
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 5 months ago (2014-07-23 02:35:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/393123004/40001
6 years, 5 months ago (2014-07-23 02:37:32 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 5 months ago (2014-07-23 07:06:38 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-23 07:55:46 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/31314)
6 years, 5 months ago (2014-07-23 07:55:47 UTC) #9
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 5 months ago (2014-07-23 12:47:26 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/393123004/40001
6 years, 5 months ago (2014-07-23 12:48:54 UTC) #11
commit-bot: I haz the power
6 years, 5 months ago (2014-07-23 14:09:09 UTC) #12
Message was sent while issue was closed.
Change committed as 284912

Powered by Google App Engine
This is Rietveld 408576698