Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1299)

Unified Diff: extensions/extensions_strings.gyp

Issue 393123004: Cleanup usage of hard_dependency in grit targets. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: REBASE Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/components_strings.gyp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/extensions_strings.gyp
diff --git a/extensions/extensions_strings.gyp b/extensions/extensions_strings.gyp
index 3adaeb256616c249aeeed145613a84fa7d0abf74..69f87ff2a2275a11e21e1b495e5fcefa89e1a5e8 100644
--- a/extensions/extensions_strings.gyp
+++ b/extensions/extensions_strings.gyp
@@ -8,24 +8,19 @@
# GN version: //extensions:strings
'target_name': 'extensions_strings',
'type': 'none',
+ 'variables': {
+ 'grit_out_dir': '<(SHARED_INTERMEDIATE_DIR)/extensions/strings',
+ },
'actions': [
{
'action_name': 'generate_extensions_strings',
'variables': {
'grit_grd_file': 'extensions_strings.grd',
- 'grit_out_dir': '<(SHARED_INTERMEDIATE_DIR)/extensions/strings',
},
'includes': [ '../build/grit_action.gypi' ],
},
],
- 'direct_dependent_settings': {
- 'include_dirs': [
- '<(SHARED_INTERMEDIATE_DIR)/extensions/strings',
- ],
- },
- # This target generates extensions_strings.h so it must be built before
- # targets that depend on it.
- 'hard_dependency': 1,
+ 'includes': [ '../build/grit_target.gypi' ],
},
],
}
« no previous file with comments | « components/components_strings.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698