Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Issue 39308: Allow clicks to windows disabled by modal dialogs to bring the entire modal s... (Closed)

Created:
11 years, 9 months ago by Ben Goodger (Google)
Modified:
9 years, 6 months ago
Reviewers:
Finnur
CC:
chromium-reviews_googlegroups.com
Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/
Visibility:
Public.

Description

Allow clicks to windows disabled by modal dialogs to bring the entire modal stack to the front. Apparently you need to let DefWindowProc handle WM_SETCURSOR unless you want clicks to background disabled windows to get lost. http://crbug.com/8437 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=11198

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M chrome/views/window.cc View 1 2 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Ben Goodger (Google)
11 years, 9 months ago (2009-03-07 07:04:05 UTC) #1
Finnur
11 years, 9 months ago (2009-03-07 07:34:27 UTC) #2
Huh... Interesting.

LGTM.

Powered by Google App Engine
This is Rietveld 408576698